Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mtk-v5.15-dev-rity-kirkstone-v24.0 doesnt compile #359

Open
Rippanda12 opened this issue Aug 29, 2024 · 2 comments
Open

mtk-v5.15-dev-rity-kirkstone-v24.0 doesnt compile #359

Rippanda12 opened this issue Aug 29, 2024 · 2 comments

Comments

@Rippanda12
Copy link

Rippanda12 commented Aug 29, 2024 •
edited
Loading 

drivers/soc/mediatek/hdmirx/hdmi_rx2_cmd.c:27:10: fatal error: mtk_hdmirx.h: No such file or directory
   27 | #include <mtk_hdmirx.h>
      |          ^~~~~~~~~~~~~~
compilation terminated.
make[4]: *** [scripts/Makefile.build:288: drivers/soc/mediatek/hdmirx/hdmi_rx2_cmd.o] Error 1

Adding this to drivers/soc/mediatek/hdmirx/Makefile makes it compile

ccflags-y += -I$(srctree)/drivers/soc/mediatek/hdmirx/

Same for

In file included from drivers/media/platform/mediatek/mdp3/mtk-img-ipi.h:14,
                 from drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.h:13,
                 from drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.h:10,
                 from drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.h:15,
                 from drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c:16:
drivers/media/platform/mediatek/mdp3/mt8183/mdp3-comp-mt8183.h:10:10: fatal error: mtk-mdp3-type.h: No such file or directory
   10 | #include "mtk-mdp3-type.h"
      |          ^~~~~~~~~~~~~~~~~
compilation terminated.
make[5]: *** [scripts/Makefile.build:288: drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.o] Error 1
make[5]: *** Waiting for unfinished jobs....
  CC [M]  drivers/media/rc/keymaps/rc-asus-pc39.o
  CC [M]  drivers/usb/serial/usb_wwan.o
In file included from drivers/media/platform/mediatek/mdp3/mtk-img-ipi.h:14,
                 from drivers/media/platform/mediatek/mdp3/mtk-mdp3-vpu.h:11,
                 from drivers/media/platform/mediatek/mdp3/mtk-mdp3-vpu.c:9:
drivers/media/platform/mediatek/mdp3/mt8183/mdp3-comp-mt8183.h:10:10: fatal error: mtk-mdp3-type.h: No such file or directory
   10 | #include "mtk-mdp3-type.h"
      |          ^~~~~~~~~~~~~~~~~
compilation terminated.

Adding this to /drivers/media/platform/mediatek/mdp3/Makefile

ccflags-y += -I$(srctree)/drivers/media/platform/mediatek/mdp3
@RadxaStephen
Copy link
Member

RadxaStephen commented Oct 10, 2024 •
edited
Loading

Can you show me your full build command on your PC? What is your Host PC?

@Rippanda12
Copy link
Author

Rippanda12 commented Oct 12, 2024 •
edited
Loading

https://github.com/BredOS/sbc-pkgbuilds/blob/f9fd9a1eaf4e922b4516b052762835ca3d21c044/linux-mediatek/PKGBUILD#L30-L44

https://github.com/BredOS/sbc-pkgbuilds/blob/main/linux-mediatek/config

I'm building on native arm no cross compilation

LeddaZ pushed a commit to LeddaZ/radxa-kernel that referenced this issue Feb 5, 2025
@ummakynes @gregkh
netfilter: nf_tables: flush pending destroy work before exit_net release
4e8447a 
commit 24cea96 upstream.

Similar to 2c9f029 ("netfilter: nf_tables: flush pending destroy
work before netlink notifier") to address a race between exit_net and
the destroy workqueue.

The trace below shows an element to be released via destroy workqueue
while exit_net path (triggered via module removal) has already released
the set that is used in such transaction.

[ 1360.547789] BUG: KASAN: slab-use-after-free in nf_tables_trans_destroy_work+0x3f5/0x590 [nf_tables]
[ 1360.547861] Read of size 8 at addr ffff888140500cc0 by task kworker/4:1/152465
[ 1360.547870] CPU: 4 PID: 152465 Comm: kworker/4:1 Not tainted 6.8.0+ radxa#359
[ 1360.547882] Workqueue: events nf_tables_trans_destroy_work [nf_tables]
[ 1360.547984] Call Trace:
[ 1360.547991]  <TASK>
[ 1360.547998]  dump_stack_lvl+0x53/0x70
[ 1360.548014]  print_report+0xc4/0x610
[ 1360.548026]  ? __virt_addr_valid+0xba/0x160
[ 1360.548040]  ? __pfx__raw_spin_lock_irqsave+0x10/0x10
[ 1360.548054]  ? nf_tables_trans_destroy_work+0x3f5/0x590 [nf_tables]
[ 1360.548176]  kasan_report+0xae/0xe0
[ 1360.548189]  ? nf_tables_trans_destroy_work+0x3f5/0x590 [nf_tables]
[ 1360.548312]  nf_tables_trans_destroy_work+0x3f5/0x590 [nf_tables]
[ 1360.548447]  ? __pfx_nf_tables_trans_destroy_work+0x10/0x10 [nf_tables]
[ 1360.548577]  ? _raw_spin_unlock_irq+0x18/0x30
[ 1360.548591]  process_one_work+0x2f1/0x670
[ 1360.548610]  worker_thread+0x4d3/0x760
[ 1360.548627]  ? __pfx_worker_thread+0x10/0x10
[ 1360.548640]  kthread+0x16b/0x1b0
[ 1360.548653]  ? __pfx_kthread+0x10/0x10
[ 1360.548665]  ret_from_fork+0x2f/0x50
[ 1360.548679]  ? __pfx_kthread+0x10/0x10
[ 1360.548690]  ret_from_fork_asm+0x1a/0x30
[ 1360.548707]  </TASK>

[ 1360.548719] Allocated by task 192061:
[ 1360.548726]  kasan_save_stack+0x20/0x40
[ 1360.548739]  kasan_save_track+0x14/0x30
[ 1360.548750]  __kasan_kmalloc+0x8f/0xa0
[ 1360.548760]  __kmalloc_node+0x1f1/0x450
[ 1360.548771]  nf_tables_newset+0x10c7/0x1b50 [nf_tables]
[ 1360.548883]  nfnetlink_rcv_batch+0xbc4/0xdc0 [nfnetlink]
[ 1360.548909]  nfnetlink_rcv+0x1a8/0x1e0 [nfnetlink]
[ 1360.548927]  netlink_unicast+0x367/0x4f0
[ 1360.548935]  netlink_sendmsg+0x34b/0x610
[ 1360.548944]  ____sys_sendmsg+0x4d4/0x510
[ 1360.548953]  ___sys_sendmsg+0xc9/0x120
[ 1360.548961]  __sys_sendmsg+0xbe/0x140
[ 1360.548971]  do_syscall_64+0x55/0x120
[ 1360.548982]  entry_SYSCALL_64_after_hwframe+0x55/0x5d

[ 1360.548994] Freed by task 192222:
[ 1360.548999]  kasan_save_stack+0x20/0x40
[ 1360.549009]  kasan_save_track+0x14/0x30
[ 1360.549019]  kasan_save_free_info+0x3b/0x60
[ 1360.549028]  poison_slab_object+0x100/0x180
[ 1360.549036]  __kasan_slab_free+0x14/0x30
[ 1360.549042]  kfree+0xb6/0x260
[ 1360.549049]  __nft_release_table+0x473/0x6a0 [nf_tables]
[ 1360.549131]  nf_tables_exit_net+0x170/0x240 [nf_tables]
[ 1360.549221]  ops_exit_list+0x50/0xa0
[ 1360.549229]  free_exit_list+0x101/0x140
[ 1360.549236]  unregister_pernet_operations+0x107/0x160
[ 1360.549245]  unregister_pernet_subsys+0x1c/0x30
[ 1360.549254]  nf_tables_module_exit+0x43/0x80 [nf_tables]
[ 1360.549345]  __do_sys_delete_module+0x253/0x370
[ 1360.549352]  do_syscall_64+0x55/0x120
[ 1360.549360]  entry_SYSCALL_64_after_hwframe+0x55/0x5d

(gdb) list *__nft_release_table+0x473
0x1e033 is in __nft_release_table (net/netfilter/nf_tables_api.c:11354).
11349           list_for_each_entry_safe(flowtable, nf, &table->flowtables, list) {
11350                   list_del(&flowtable->list);
11351                   nft_use_dec(&table->use);
11352                   nf_tables_flowtable_destroy(flowtable);
11353           }
11354           list_for_each_entry_safe(set, ns, &table->sets, list) {
11355                   list_del(&set->list);
11356                   nft_use_dec(&table->use);
11357                   if (set->flags & (NFT_SET_MAP | NFT_SET_OBJECT))
11358                           nft_map_deactivate(&ctx, set);
(gdb)

[ 1360.549372] Last potentially related work creation:
[ 1360.549376]  kasan_save_stack+0x20/0x40
[ 1360.549384]  __kasan_record_aux_stack+0x9b/0xb0
[ 1360.549392]  __queue_work+0x3fb/0x780
[ 1360.549399]  queue_work_on+0x4f/0x60
[ 1360.549407]  nft_rhash_remove+0x33b/0x340 [nf_tables]
[ 1360.549516]  nf_tables_commit+0x1c6a/0x2620 [nf_tables]
[ 1360.549625]  nfnetlink_rcv_batch+0x728/0xdc0 [nfnetlink]
[ 1360.549647]  nfnetlink_rcv+0x1a8/0x1e0 [nfnetlink]
[ 1360.549671]  netlink_unicast+0x367/0x4f0
[ 1360.549680]  netlink_sendmsg+0x34b/0x610
[ 1360.549690]  ____sys_sendmsg+0x4d4/0x510
[ 1360.549697]  ___sys_sendmsg+0xc9/0x120
[ 1360.549706]  __sys_sendmsg+0xbe/0x140
[ 1360.549715]  do_syscall_64+0x55/0x120
[ 1360.549725]  entry_SYSCALL_64_after_hwframe+0x55/0x5d

Fixes: 0935d55 ("netfilter: nf_tables: asynchronous release")
Signed-off-by: Pablo Neira Ayuso <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Rippanda12 @RadxaStephen