Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction operation #7

Open
arlenmendes opened this issue Aug 30, 2019 · 5 comments
Open

Transaction operation #7

arlenmendes opened this issue Aug 30, 2019 · 5 comments
Labels
enhancement New feature or request requires upstream fix Requires fixing in the @adonis/lucid package

Comments

@arlenmendes
Copy link

This don't work with transaction database of lucid

@radmen
Copy link
Owner

radmen commented Sep 2, 2019

@arlenmendes thanks for feedback.

This is true, however, the same applies to the original delete method. I could probably add support for transactions (by passing trx parameter), yet this is something that won't be compatible with the original API.

I'd like to see this fix done in the Lucid first so that I can re-apply it to this trait.

@radmen
Copy link
Owner

radmen commented Sep 2, 2019

There's even an open ticket for that - adonisjs/lucid#447

@arlenmendes
Copy link
Author

Got it... but have you ever figured out that this will be implemented?

I have an app offline first and I need this in sync function.

@radmen
Copy link
Owner

radmen commented Sep 5, 2019

@arlenmendes this should be fairly easy to fix. When I'll find the time I will push a fix to upstream and then re-merge it to this package.

@arlenmendes
Copy link
Author

Thank you very much for your attention.

@radmen radmen added requires upstream fix Requires fixing in the @adonis/lucid package enhancement New feature or request labels Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request requires upstream fix Requires fixing in the @adonis/lucid package
Projects
None yet
Development

No branches or pull requests

2 participants