Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: NumberField does not change the value on enter (triggers form submit keeping the previews value) #1385

Closed
2 tasks
pcaselas opened this issue Sep 19, 2024 · 0 comments · Fixed by #1395
Closed
2 tasks
Assignees
Labels
bug Something isn't working

Comments

@pcaselas
Copy link

Reproduction

https://codesandbox.io/p/devbox/shadcn-vue-numberfieldform-forked-m5yrgq

Describe the bug

On the page https://www.shadcn-vue.com/docs/components/number-field.html

In the last example, if you change the number and press the enter key without doing any kind of blur, the form submits the value, but the value change is not reflected.

number_field

System Info

System:
    OS: macOS 14.6.1
    CPU: (12) arm64 Apple M3 Pro
    Memory: 74.47 MB / 18.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.20.4 - ~/.nvm/versions/node/v18.20.4/bin/node
    npm: 10.7.0 - ~/.nvm/versions/node/v18.20.4/bin/npm
  Browsers:
    Brave Browser: 127.1.68.141
    Chrome Canary: 131.0.6726.0
    Edge: 128.0.2739.79
    Safari: 17.6

Contributes

  • I am willing to submit a PR to fix this issue
  • I am willing to submit a PR with failing tests
@pcaselas pcaselas added the bug Something isn't working label Sep 19, 2024
@sadeghbarati sadeghbarati transferred this issue from unovue/shadcn-vue Oct 22, 2024
@zernonia zernonia self-assigned this Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants