Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: drawer component does not respect typescript: false in components.json #732

Open
1 of 2 tasks
gigabites19 opened this issue Aug 26, 2024 · 4 comments
Open
1 of 2 tasks
Labels
bug Something isn't working detypes Generate vanilla JavaScript samples from TypeScript

Comments

@gigabites19
Copy link
Contributor

Reproduction

https://stackblitz.com/edit/vitejs-vite-zrsheh

Describe the bug

When you run npx shadcn-vue@latest add drawer and you have typescript: false in your components.json, following drawer-related components still use typescript:

  • DrawerDescription.vue
  • DrawerFooter.vue
  • DrawerHeader.vue
  • DrawerOverlay.vue
  • DrawerTitle.vue

In the reproduction run npx shadcn-vue@latest add drawer and inspect components above, they will be using ts

System Info

System:
    OS: Linux 6.1 Manjaro Linux
    CPU: (8) x64 AMD Ryzen 5 1400 Quad-Core Processor
    Memory: 9.40 GB / 15.53 GB
    Container: Yes
    Shell: 5.2.32 - /bin/bash
  Binaries:
    Node: 20.17.0 - ~/.nvm/versions/node/v20.17.0/bin/node
    npm: 10.8.2 - ~/.nvm/versions/node/v20.17.0/bin/npm

Contributes

  • I am willing to submit a PR to fix this issue
  • I am willing to submit a PR with failing tests
@gigabites19 gigabites19 added the bug Something isn't working label Aug 26, 2024
@gigabites19
Copy link
Contributor Author

I also want to say, thank you @zernonia @sadeghbarati and others for this project, I find it super useful and of course, beautiful.

@sadeghbarati sadeghbarati added the detypes Generate vanilla JavaScript samples from TypeScript label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working detypes Generate vanilla JavaScript samples from TypeScript
Projects
None yet
Development

No branches or pull requests

5 participants
@sadeghbarati @gigabites19 and others