Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Adding charts page to website #652

Open
1 of 2 tasks
Saeid-Za opened this issue Jul 8, 2024 · 4 comments
Open
1 of 2 tasks

[Feature]: Adding charts page to website #652

Saeid-Za opened this issue Jul 8, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@Saeid-Za
Copy link
Contributor

Saeid-Za commented Jul 8, 2024

Describe the feature

With the new release of shadcn/ui and it's charts page, we would need a new charts page and new chart samples.

This shouldn't be a time consuming task, as we have the base components.

Additional information

  • I intend to submit a PR for this feature.
  • I have already implemented and/or tested this feature.
@sadeghbarati sadeghbarati added the enhancement New feature or request label Jul 9, 2024
@zernonia
Copy link
Member

Yo @Saeid-Za .. not sure how far along with your PR. As shadcn has released the official Chart I'm planning to update the chart component, especially the Base Chart to reflect the similar API as in the original.

@Saeid-Za
Copy link
Contributor Author

Hello There, I'll be submitting the PR in a couple of Hours, unfortunately I haven't had the time to make much progress on it.
The base components weren't very helpful as the charts needed to expose finer control to the developer.

@kikky7
Copy link
Contributor

kikky7 commented Aug 9, 2024

Hi, is this feature bringing same charts as on official shadcn web? Because when I implement charts from current examples, they don't look or behave same as official component.

Will it be merged soon or there is no scheduled release?

@Saeid-Za
Copy link
Contributor Author

@zernonia hi there, do you still need help on this? Would be happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants