Overriding update() for Service resource; getting rid of update logic in PersistentResource.

Author: ycombinator

lib/OpenCloud/CDN/Resource/Service.php

@@ -30,8 +30,6 @@ class Service extends PersistentResource
     protected static $url_resource = 'services';
     protected static $json_name = 'service';
 
-    const UPDATE_METHOD = 'PATCH';
-
     protected $id;
     protected $name;
     protected $domains;
@@ -99,4 +97,19 @@ protected function createJson()
         $createJson = parent::createJson();
         return $createJson->{self::$json_name};
     }
+
+    /**
+     * Update this resource
+     *
+     * @param array $params
+     * @return \Guzzle\Http\Message\Response
+     */
+    public function update($params = array())
+    {
+        $json = $this->generateJsonPatch($params);
+
+        return $this->getClient()
+            ->patch($this->getUrl(), $this->getPatchHeaders(), $json)
+            ->send();
+    }
 }

lib/OpenCloud/Common/Resource/PersistentResource.php

@@ -29,8 +29,6 @@
 
 abstract class PersistentResource extends BaseResource
 {
-    const UPDATE_METHOD = 'PUT';
-
     /**
      * Create a new resource
      *
@@ -82,13 +80,7 @@ public function update($params = array())
         $this->checkJsonError();
 
         // send the request
-        return $this->makeUpdateRequest($json);
-    }
-
-    protected function makeUpdateRequest($json)
-    {
-        $updateMethod = ('PATCH' === static::UPDATE_METHOD) ? 'patch' : 'post';
-        return $this->getClient()->$updateMethod($this->getUrl(), self::getJsonHeader(), $json)->send();
+        return $this->getClient()->put($this->getUrl(), self::getJsonHeader(), $json)->send();
     }
 
     /**