Using property aliases when generating JSON Patch representation.

Author: ycombinator

lib/OpenCloud/Common/Resource/PersistentResource.php

@@ -375,6 +375,10 @@ protected function generateJsonPatch($updatedProperties)
             }
         }
 
+        // Recursively alias current and updated properties
+        $currentProperties = $this->recursivelyAliasPropertyValue($currentProperties);
+        $updatedProperties = $this->recursivelyAliasPropertyValue($updatedProperties);
+
         // Generate JSON Patch representation
         $json = json_encode(JsonPatch::diff($currentProperties, $updatedProperties));
         $this->checkJsonError();

tests/OpenCloud/Tests/Common/Resource/PersistentResourceTest.php

@@ -165,6 +165,7 @@ public function testGenerateJsonPatch()
             array('origin' => 'origin1.phpopencloud.com')
         );
         $this->persistentResource->status = array('message' => 'Creation in progress');
+        $this->persistentResource->baz = (object) array( 'fooBar' => 'barbar');
 
         $updateParams = array(
             'tags'    => array('foo', 'qux', 'baz'),
@@ -174,10 +175,12 @@ public function testGenerateJsonPatch()
             'origins' => array(
                 array('origin' => 'origin1.phpopencloud.com'),
                 array('origin' => 'origin2.phpopencloud.com')
-            )
+            ),
+            'baz' => array('fooBar' => 'barbarbar')
         );
 
         $expectedJsonPatch = json_encode(array(
+            array('op' => 'replace', 'path' => '/baz/foo_bar', 'value' => 'barbarbar'),
             array('op' => 'add', 'path' => '/tags/2', 'value' => 'baz'),
             array('op' => 'replace', 'path' => '/tags/1', 'value' => 'qux'),
             array('op' => 'remove', 'path' => '/domains/1'),