Skip to content

Commit 5de5490

Browse files
authored
Remove unused code in glyph drawing code (#128)
The original intent of the `when` block was to remove the line around the glyph when the line and fill color were the same. However, the `eq?` test was always false in Typed Racket, so the code never executed. The `eq?` test is now fixed in racket/typed-racket#1358, but as a result, the visual layout of plots would change, making glyphs smaller, since the outline is not drawn anymore. To keep the backwards compatibility of the plot look-and-feel, the entire `when` block was removed.
1 parent 2417c22 commit 5de5490

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

plot-lib/plot/private/common/plot-device.rkt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -546,9 +546,6 @@
546546
(define r (* 1/2 size))
547547
(define line-sym
548548
(cond [(hash-has-key? full-glyph-hash real-sym)
549-
(when (eq? pen-color brush-color)
550-
(set-pen pen-color 1 'transparent)
551-
(set-brush brush-color 'solid))
552549
(hash-ref full-glyph-hash real-sym)]
553550
[else (set-brush brush-color 'transparent)
554551
real-sym]))

0 commit comments

Comments
 (0)