Public view vs external&internal view

[Quazia]

There's a few places we use a public view where we could have an internal view that's accessible by way of another external view.

For example:

    function getNftQuestFee(address address_) public view returns (uint256) {
        return nftQuestFeeList[address_].exists ? nftQuestFeeList[address_].fee : nftQuestFee;
    }

Would become:

    function getNftQuestFee(address address_) external view returns (uint256) {
        _getNftQuestFee(address_);
    }
     
     function _getNftQuestFee(address address_) internal view returns (uint256) {
        return nftQuestFeeList[address_].exists ? nftQuestFeeList[address_].fee : nftQuestFee;
    }

[waynehoover]

Could you tell me what the reason is for this change?

[Quazia]

It's just a gas improvement, not super pressing. As far as I know internal and external are both more efficient than public. It's possible recent compiler optimizations have made this an outdated optimization and I think if you crank the solc optimization up enough it actually handles stuff like this. I can wait and do the gas testing before making this change so we can see sure. It takes up more storage in exchange for a little cheaper execution. You see a lot more benefit in situations where you're calling the same public function multiple times internally.