Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hebr/he] example cantillation text has poor mark placement #146

Closed
bdenckla opened this issue Apr 13, 2023 · 7 comments
Closed

[hebr/he] example cantillation text has poor mark placement #146

bdenckla opened this issue Apr 13, 2023 · 7 comments
Labels

Comments

@bdenckla
Copy link

[source] https://r12a.github.io/scripts/hebr/he

Original:

image

With blue arrows highlighting the two placement issues:

Genesis r12a trope placement issues

Example of text without these issues:
image
image

@r12a r12a added the hebr label Apr 15, 2023
@r12a
Copy link
Owner

r12a commented Apr 15, 2023

The page uses a Noto Serif Hebrew webfont.

Btw, i can't tell whether this should be 0599 HEBREW ACCENT PASHTA or 05A8 HEBREW ACCENT QADMA. It makes a difference in Ezra SIL SR, Times New Roman and Tahoma.

Which font and code point are you using?

@bdenckla
Copy link
Author

bdenckla commented Apr 15, 2023

Wait but here we're talking about an image generated using what is probably different font than the font used on the page for real text, right? And then coloring was added, which is probably what messed up the mark placement, since in general it is impossible to add coloring to marks without messing up placement, although I know specific people who have had success with adding color, using specific software and specific techniques within that software.

As for whether that mark on the tav should be created by U-PASHTA or U-QADMA... that's a darn good question, one I get into in #157. Semantically (abstractly), it should be U-PASHTA. But concretely, visually, placement-wise, U-QADMA is a "cheat" to get the central placement you want without requiring the font to be "smart". As I mentioned above, I suspect the coloring defeated the font's "smarts", so this might be one rare case where I would, regrettable, advise to use U-QADMA. And then once you've generated the image, destroy the Unicode source file evidence.

Perhaps a good approach to generating small examples where only marks are colored, like this, would be to generate an SVG and then edit the resulting SVG in an SVG editor. I think harfbuzz has a utility that will generate an SVG from a string; there's probably other software that can do it as well. I guess any SVG editor will allow you to put text in and then created an SVG from that and then you could import that SVG back into the SVG editor and manipulate the color of the marks there.

@bdenckla
Copy link
Author

bdenckla commented Apr 15, 2023

As to what font I used to create the image I provided, I am using my own font, https://bdenckla.github.io/Taamey_D/.

@r12a
Copy link
Owner

r12a commented Apr 15, 2023

The colourisation didn't change anything. I create the text in a web page, then take a screen grab in the highlight colour, then change the colour (of the whole thing), and screen grab again. Then in PhotoShop i place one image over the other and delete where the highlight needs to shine through. So no effect at all on placement.

Usually i record the actual font used and the size in the image element attributes, but this is an old image dating from before i did that consistently :(

@bdenckla
Copy link
Author

I create the text in a web page, then take a screen grab in the highlight colour, then change the colour (of the whole thing), and screen grab again. Then in PhotoShop i place one image over the other and delete where the highlight needs to shine through. So no effect at all on placement.

Interesting technique!

@r12a
Copy link
Owner

r12a commented Apr 15, 2023

I replaced the image with a new one, using the Ezra SIL SR font which allowed me to use the correct code points and (hopefully) produces something close enough to what's expected. (Click on the image, as usual for recent figures, to see the composition.)

https://r12a.github.io/scripts/hebr/he.html#fig_diacritics

@bdenckla
Copy link
Author

The new image looks great. SIL Ezra is a great choice for this. I like the new coloring where cantillation marks have a different color that other marks. Pasting the image in here just to have a one-stop record of what we're talking about.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants