Wrong naming conventions

[chandrucrypto]

This action does the great job, but I didn't understand the fact that why it generates app-release-unsigned-signed.apk. Can't it not be app-realease.apk to make the process simple? Also why do we need to do ./gradlew assembleRelease every time before calling r0adkll/sign-android-release@v1 as this can be called inside the action library itself..

[joakimcarlgren]

Hi @r0adkll
This is not a big deal, however a bit annoying that the signing step simply appends "-signed" onto the artifact, when there's an "-unsigned" already part of the name.

The ideal solution would be to check if there is "-unsigned" part of the name, and then replace that with "-signed", or provide the ability to set a name of the final signed apk/aab

ref:

sign-android-release/src/signing.ts

Line 48 in 349ebde

const signedApkFile = apkFile.replace('.apk', '-signed.apk');