Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not signing, but no error? #44

Open
DJ-Ascendum opened this issue Jun 2, 2021 · 4 comments
Open

Not signing, but no error? #44

DJ-Ascendum opened this issue Jun 2, 2021 · 4 comments

Comments

@DJ-Ascendum
Copy link

Hi there!

I seem to be having an issue getting my builds to sign. here is the debug log. I don't see any indication it tried to sign.


##[debug]Evaluating condition for step: 'Sign APK'
##[debug]Evaluating: success()
##[debug]Evaluating success:
##[debug]=> true
##[debug]Result: true
##[debug]Starting: Sign APK
##[debug]Loading inputs
##[debug]Evaluating: secrets.ANDROID_BASE64_SIGNING_KEY
##[debug]Evaluating Index:
##[debug]..Evaluating secrets:
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'ANDROID_BASE64_SIGNING_KEY'
##[debug]=> '***'
##[debug]Result: '***'
##[debug]Evaluating: secrets.ANDROID_KEY_ALIAS
##[debug]Evaluating Index:
##[debug]..Evaluating secrets:
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'ANDROID_KEY_ALIAS'
##[debug]=> '***'
##[debug]Result: '***'
##[debug]Evaluating: secrets.ANDROID_KEY_STORE_PASSWORD
##[debug]Evaluating Index:
##[debug]..Evaluating secrets:
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'ANDROID_KEY_STORE_PASSWORD'
##[debug]=> '***'
##[debug]Result: '***'
##[debug]Evaluating: secrets.ANDROID_KEY_PASSWORD
##[debug]Evaluating Index:
##[debug]..Evaluating secrets:
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'ANDROID_KEY_PASSWORD'
##[debug]=> '***'
##[debug]Result: '***'
##[debug]Loading env

Run r0adkll/[email protected]
  with:
    releaseDirectory: android/app/build/outputs/apk/prod/release/
    signingKeyBase64: ***
    alias: ***
    keyStorePassword: ***
    keyPassword: ***

Waiting  milliseconds ...
##[debug]14:41:54 GMT+0000 (Coordinated Universal Time)
##[debug]14:41:54 GMT+0000 (Coordinated Universal Time)
##[set-output name=time;]14:41:54 GMT+0000 (Coordinated Universal Time)
##[debug]steps.sign_app.outputs.time='14:41:54 GMT+0000 (Coordinated Universal Time)'
##[debug]Node Action run completed with exit code 0
##[debug]Finishing: Sign APK

I output the directory contents and confirmed there is an APK there, and it's listed as unsigned still.

Run ls android/app/build/outputs/apk/prod/release/ -a
.
..
app-prod-release-unsigned.apk
output-metadata.json
##[debug]Finishing: List folder contents

Then. naturally, the upload to the play store fails:

Error: Error: APK signature is invalid or does not exist. Error from apksigner: ERROR: JAR_SIG_NO_SIGNATURES: No JAR signatures

Any idea what's happening here? I've tried replacing the keys and the base64 key several times, and no change.

@DJ-Ascendum
Copy link
Author

@r0adkll Any insights?

@DJ-Ascendum
Copy link
Author

Anyone?

@Zlate87
Copy link

Zlate87 commented Jan 26, 2022

I run into the same problem.

@Zlate87
Copy link

Zlate87 commented Jan 26, 2022

downgrading to sign-android-release@v1 from [email protected] solved the problem for me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants