Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for strings on the LHS of function definitions #147

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MichaelChirico
Copy link

Closes #143

@MichaelChirico MichaelChirico marked this pull request as ready for review September 26, 2024 16:43
@MichaelChirico
Copy link
Author

I think the new tests are good & look like they're passing so my edits to tags.scm are WAI? My first time touching tree-sitter so please hand-hold if that's wrong 🙏

I think backticked names were already captured, but adding a test here since that's a useful edge case to keep tabs on.

I wonder if shorthand-lambdas should be included as well, but decided against it as out-of-scope for this PR for now, WDYT?

@MichaelChirico
Copy link
Author

Friendly ping! If you're swamped that's fine, just reminding before I forget about it myself :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tags.scm should probably recognize functions with string names on the LHS
2 participants