Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should warn set immediate. = !is_interactive()? #1397

Open
hadley opened this issue Apr 27, 2022 · 2 comments
Open

Should warn set immediate. = !is_interactive()? #1397

hadley opened this issue Apr 27, 2022 · 2 comments
Labels
cnd feature a feature request or enhancement
Milestone

Comments

@hadley
Copy link
Member

hadley commented Apr 27, 2022

So you can see all warnings even when you can't run warnings().

@lionel-
Copy link
Member

lionel- commented Apr 28, 2022

The problem is that the warnings might be thrown in a tight loop and displaying them all will flood the logs. So we we'd probably need a way to count the number of warnings emitted during the current command and stop displaying them after a threshold has been reached. At this point we'd be in full control of the warning display, like we do with messages and errors.

@hadley
Copy link
Member Author

hadley commented Apr 28, 2022

An alternative approach would be to come up with a patch for base R. I think there's two features that would be nice:

  • Some way to set the warning threshold to something other than 10
  • When the warnings are over the threshold, still display the first n warnings.

@lionel- lionel- added cnd feature a feature request or enhancement labels May 25, 2022
@lionel- lionel- modified the milestones: future, maybe May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cnd feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants