Extract curl_fetch_memory()

Author: krlmlr

R/github.R

@@ -10,13 +10,7 @@ github_GET <- function(path, ..., host = "api.github.com", pat = github_pat(), u
       }
     )
 
-    h <- curl::new_handle()
-    curl::handle_setheaders(h, .list = headers)
-    res <- curl::curl_fetch_memory(url, handle = h)
-
-    if (res$status_code >= 300) {
-      stop(github_error(res))
-    }
+    res <- curl_fetch_memory(url, headers)
     json$parse(raw_to_char_utf8(res$content))
   } else {
     tmp <- tempfile()
@@ -42,15 +36,11 @@ github_commit <- function(username, repo, ref = "HEAD",
       }
     )
 
-    h <- curl::new_handle()
-    curl::handle_setheaders(h, .list = headers)
-    res <- curl::curl_fetch_memory(url, handle = h)
+    res <- curl_fetch_memory(url, headers, accept == 304)
+
     if (res$status_code == 304) {
       return(current_sha)
     }
-    if (res$status_code >= 300) {
-      stop(github_error(res))
-    }
 
     raw_to_char_utf8(res$content)
   } else {
@@ -124,12 +114,8 @@ github_DESCRIPTION <- function(username, repo, subdir = NULL, ref = "HEAD", host
       }
     )
 
-    h <- curl::new_handle()
-    curl::handle_setheaders(h, .list = headers)
-    res <- curl::curl_fetch_memory(url, handle = h)
-    if (res$status_code >= 300) {
-      stop(github_error(res))
-    }
+    res <- curl_fetch_memory(url, headers)
+
     raw_to_char_utf8(res$content)
   } else {
     tmp <- tempfile()
@@ -142,6 +128,20 @@ github_DESCRIPTION <- function(username, repo, subdir = NULL, ref = "HEAD", host
   }
 }
 
+curl_fetch_memory <- function(url, headers, accept = NULL) {
+  h <- curl::new_handle()
+  curl::handle_setheaders(h, .list = headers)
+  res <- curl::curl_fetch_memory(url, handle = h)
+
+  if (!(res$status_code %in% accept)) {
+    if (res$status_code >= 300) {
+      stop(github_error(res))
+    }
+  }
+
+  res
+}
+
 github_error <- function(res) {
   res_headers <- curl::parse_headers_list(res$headers)