Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if_not_else_linter() for "double negation" in if statements #2071

Merged
merged 14 commits into from
Aug 31, 2023

Conversation

MichaelChirico
Copy link
Collaborator

Part of #884.

Internally, we use the default exceptions=, but I'd be open to setting that to character() by default, or extending the current list.

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2023

Codecov Report

Merging #2071 (81b518f) into main (15a22fe) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 81b518f differs from pull request most recent head e8f755d. Consider uploading reports for the commit e8f755d to get more accurate results

@@           Coverage Diff           @@
##             main    #2071   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files         117      118    +1     
  Lines        5164     5201   +37     
=======================================
+ Hits         5146     5183   +37     
  Misses         18       18           
Files Changed Coverage Δ
R/if_not_else_linter.R 100.00% <100.00%> (ø)
R/xp_utils.R 100.00% <100.00%> (ø)

@MichaelChirico MichaelChirico merged commit cafc081 into main Aug 31, 2023
21 checks passed
@MichaelChirico MichaelChirico deleted the if_not_else branch August 31, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants