-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release lintr 3.2.0 #2392
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@AshesITR with the CRAN failure (#2527), let's decide how to proceed. Options I see:
#2325 is also not strictly required for this release, but we have the implementation ready & just need to decide on argument naming/defaults IIRC. Let me know your thoughts based on your availability in the next two weeks or so. |
I won't be able to contribute anything meaningful in the upcoming weeks unfortunately. My hunch is option 1 (maybe including the maintainer change) is the least risky, but I trust your judgement. |
SGTM! FYI (cc also @IndrajeetPatil), I don't plan any major change from taking over maintainership, I just think of it as passing responsibility for the actual CRAN submission process from Jim to me. GH review/etc process has been working pretty well in general. |
@MichaelChirico, @AshesITR Should we make a new release soon? I am taking the amount of time it takes for me to scroll NEWS to get to the released version as a good indicator that enough has improved to be made available to the users. WDYT? |
Yes, we're absolutely on the precipice of release. But I'm stuck on #2431, there's a bit of a design decision there that would be harder to change after release & haven't found the time to come to a proper conclusion there yet. Opinions+insights welcome. Or, we can just mark that as "experimental/likely to change" and go ahead and release. |
Glanced at the NEWS and there's plenty there already for us to ship off to CRAN.
Prepare for release:
3.2.0
milestonebackport_linter()
covers all released R versionsurlchecker::url_check()
ortools:::check_url_db(tools:::url_db_from_package_sources("."))
R-CMD-check
GHA on all released R versions on Ubuntu, Mac, and Windows. See Check which versions of R touch the while() loop in get_source_expressions() #2501 for reference.devtools::check(remote = TRUE, manual = TRUE)
devtools::check_win_devel()
ordevtools::check_win_devel(email = "your@email")
rhub::check_for_cran()
orrhub::check_for_cran(email = "your@email")
revdepcheck::revdep_check()
. Check in revdep results #2189.dev/revdep_get_repos.R
and.dev/revdep_compare_releases.R
.Submit to CRAN:
usethis::use_version('patch')
devtools::submit_cran()
Wait for CRAN...
cran-comments.md
usethis::use_github_release()
usethis::use_dev_version()
The text was updated successfully, but these errors were encountered: