Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release lintr 3.2.0 #2392

Open
18 tasks
MichaelChirico opened this issue Dec 5, 2023 · 7 comments
Open
18 tasks

Release lintr 3.2.0 #2392

MichaelChirico opened this issue Dec 5, 2023 · 7 comments
Milestone

Comments

@MichaelChirico
Copy link
Collaborator

MichaelChirico commented Dec 5, 2023

Glanced at the NEWS and there's plenty there already for us to ship off to CRAN.

Prepare for release:

Submit to CRAN:

  • usethis::use_version('patch')
  • devtools::submit_cran()
  • Approve email

Wait for CRAN...

  • Update cran-comments.md
  • Accepted 🎉
  • usethis::use_github_release()
  • usethis::use_dev_version()
  • Toot/Tweet
@IndrajeetPatil

This comment was marked as outdated.

@MichaelChirico

This comment was marked as outdated.

@MichaelChirico MichaelChirico added this to the 3.2.0 milestone Dec 5, 2023
@MichaelChirico MichaelChirico changed the title Release lintr 3.1.2 Release lintr 3.2.0 Dec 8, 2023
@MichaelChirico
Copy link
Collaborator Author

@AshesITR with the CRAN failure (#2527), let's decide how to proceed. Options I see:

  1. Quick patch release -- branch from 3.1.1, fix only CRAN failures on R-devel #2527, release to CRAN as 3.1.2 (also mirror the change on main)
  2. Finish up the last two milestone (https://github.com/r-lib/lintr/milestone/7) issues: Should xml_find_function_calls()` land on on the parent expr instead? #2431 (related PR: New parameter 'land_on' to xml_find_function_calls() #2496), Add exception in unnecessary_nesting_linter() for paired stop()/warning() branches #2325.
  3. Delay Should xml_find_function_calls()` land on on the parent expr instead? #2431 by reverting add xml_find_function_calls() helper to source expressions #2357 for this release
  4. Delay Should xml_find_function_calls()` land on on the parent expr instead? #2431 by making note in the NEWS that add xml_find_function_calls() helper to source expressions #2357 is experimental/subject to change in the next release

#2325 is also not strictly required for this release, but we have the implementation ready & just need to decide on argument naming/defaults IIRC.

Let me know your thoughts based on your availability in the next two weeks or so.

@AshesITR
Copy link
Collaborator

I won't be able to contribute anything meaningful in the upcoming weeks unfortunately.

My hunch is option 1 (maybe including the maintainer change) is the least risky, but I trust your judgement.

@MichaelChirico
Copy link
Collaborator Author

SGTM! FYI (cc also @IndrajeetPatil), I don't plan any major change from taking over maintainership, I just think of it as passing responsibility for the actual CRAN submission process from Jim to me. GH review/etc process has been working pretty well in general.

@IndrajeetPatil
Copy link
Collaborator

@MichaelChirico, @AshesITR Should we make a new release soon?

I am taking the amount of time it takes for me to scroll NEWS to get to the released version as a good indicator that enough has improved to be made available to the users. WDYT?

@MichaelChirico
Copy link
Collaborator Author

Yes, we're absolutely on the precipice of release. But I'm stuck on #2431, there's a bit of a design decision there that would be harder to change after release & haven't found the time to come to a proper conclusion there yet. Opinions+insights welcome.

Or, we can just mark that as "experimental/likely to change" and go ahead and release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants