Skip to content

Commit 136a61b

Browse files
Remove a few linters from efficiency tag
closes #2653
1 parent 2a7bdab commit 136a61b

File tree

7 files changed

+13
-13
lines changed

7 files changed

+13
-13
lines changed

NEWS.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,9 @@
1818
* `cyclocomp_linter()` is no longer part of the default linters (#2555, @IndrajeetPatil) because the tidyverse style guide doesn't contain any guidelines on meeting certain complexity requirements. Note that users with `cyclocomp_linter()` in their configs may now need to install {cyclocomp} intentionally, in particular in CI/CD pipelines.
1919
* `scalar_in_linter` is now configurable to allow other `%in%` like operators to be linted. The data.table operator `%chin%` is no longer linted by default; use `in_operators = "%chin%"` to continue linting it. (@F-Noelle)
2020
* `lint()` and friends now normalize paths to forward slashes on Windows (@olivroy, #2613).
21+
* Following linters have been removed from efficiency linters (@IndrajeetPatil):
22+
`undesirable_function_linter()`, `undesirable_operator_linter()`, and `list_comparison_linter()`
23+
2124

2225
## Bug fixes
2326

inst/lintr/linters.csv

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ length_test_linter,common_mistakes efficiency
5252
lengths_linter,efficiency readability best_practices
5353
library_call_linter,style best_practices readability configurable
5454
line_length_linter,style readability default configurable
55-
list_comparison_linter,best_practices common_mistakes efficiency
55+
list_comparison_linter,best_practices common_mistakes
5656
literal_coercion_linter,best_practices consistency efficiency
5757
matrix_apply_linter,readability efficiency
5858
missing_argument_linter,correctness common_mistakes configurable
@@ -108,8 +108,8 @@ terminal_close_linter,best_practices robustness
108108
todo_comment_linter,style configurable
109109
trailing_blank_lines_linter,style default
110110
trailing_whitespace_linter,style default configurable
111-
undesirable_function_linter,style efficiency configurable robustness best_practices
112-
undesirable_operator_linter,style efficiency configurable robustness best_practices
111+
undesirable_function_linter,style configurable robustness best_practices
112+
undesirable_operator_linter,style configurable robustness best_practices
113113
unnecessary_concatenation_linter,style readability efficiency configurable
114114
unnecessary_lambda_linter,best_practices efficiency readability configurable
115115
unnecessary_nested_if_linter,readability best_practices deprecated

man/efficiency_linters.Rd

Lines changed: 0 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/linters.Rd

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/list_comparison_linter.Rd

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/undesirable_function_linter.Rd

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/undesirable_operator_linter.Rd

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)