-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring mocking ability to other req_perform* functions? #651
Comments
I'd consider it 😄 |
Thanks for considering it! |
Ok, I've considered it. I've realised that I would find it personally super useful to mock |
Great. Let me know if I can help in any way. |
Can you help by implementing it? 😄 |
I'll have a go at it |
I’m also happy to jump on a call and brainstorm how this might work. |
Sounds great. Let me get familiar with the package internals and then I'll ping you. Should I email you to schedule? Something else? |
Yeah, shoot me an email and I'll send you my meeting invite link. |
Of the various
req_perform*
functions (thinking mostly ofreq_perform_parallel
andreq_perform_connection
) I thinkmock
is only available inreq_perform
. Is that wrong?Would you consider adding mocking ability (whether through a parameter or via a with handler like
with_mocked_responses
) to the otherreq_perform*
functions?Use case is so that packages like vcr, webmockr, httptest2 can hook into them
The text was updated successfully, but these errors were encountered: