You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For testing and examples it would be great if httr2 had a function for checking internet connection, like testthat::skip_if_offline() or curl::has_internet(). Would it be perhaps possible of re-exporting the curl::has_internet() function?
The text was updated successfully, but these errors were encountered:
My biggest hangup here is what to call the function — currently all httr2 functions either start with req_, resp_ or url_, but none of those feel quite right. Maybe it's ok to introduce a new prefix for just this function, but that also doesn't feel quite right.
Hmmm, looking at curl::has_internet() more closely I'm pretty sure that we want to use its behaviour, rather than testthat:::has_internet(). But maybe it's ok to have httr2::is_online()
For testing and examples it would be great if httr2 had a function for checking internet connection, like
testthat::skip_if_offline()
orcurl::has_internet()
. Would it be perhaps possible of re-exporting thecurl::has_internet()
function?The text was updated successfully, but these errors were encountered: