-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement req_cookie_file() #282
Conversation
@mgirlich what do you think of the name? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks super useful! Some thoughts on the name:
req_cookie_file()
makes it feel like the thing I care about is the file, moreso than the reuse of the cookies.- Would it make sense to align it with the
cache_disk
andcache_key
options from the_auth_
functions? It's not QUITE the same thing but feels similar.
I guess the difference here is that you could conceivably supply a file from some other source, whereas caching is more internal and automatic.
So after talking it out... I can't think of anything that makes more sense to me than req_cookie_file()
.
Basically, |
Oh I like |
Co-authored-by: Maximilian Girlich <[email protected]>
@jonthegeek the implementation here is pretty limited by what curl provides; it has to be written out to disk. |
#Conflicts: # NEWS.md
Fixes #223