bugfixes; whoops i should test more

Author: qwint

APWorld/Items.py

@@ -40,8 +40,10 @@ def baseID(delta: int) -> int:
     "ItemShoes": MinitItemData(code=baseID(9), classification=prog),
     "ItemGlove": MinitItemData(code=baseID(10), classification=prog),
     "ItemBoat": MinitItemData(code=baseID(11), classification=prog),
-    # "ItemCamera": MinitItemData(code=baseID(12), classification=filler),
-    # camera will never be granted as an item for AP
+    # could be granted again, will play with the idea
+    "ItemCamera": MinitItemData(
+        code=baseID(12), classification=filler,
+        can_create=lambda world: False),
     "ItemBasement": MinitItemData(code=baseID(13), classification=prog),
     "ItemMegaSword": MinitItemData(
         code=baseID(14), classification=prog,

APWorld/Rules.py

@@ -500,16 +500,16 @@ def __init__(self, world: MinitWorld) -> None:
         # }
 
         def apply_rules(optional_rules):
-            for key, rule in optional_rules.values():
-                if key in region_rules:
+            for key, rule in optional_rules.items():
+                if key in self.region_rules:
                     self.region_rules[key] = rule
                 else:
                     self.location_rules[key] = rule
 
         if self.world.options.obscure:
             apply_rules(obscure)
 
-            if self.world.options.obscure and self.world.options.damage_boost:
+            if self.world.options.obscure and self.world.options.damage_boosts:
                 apply_rules(damage_boost_obscure)
 
         # if self.world.options.dark_room:

APWorld/__init__.py

@@ -60,15 +60,12 @@
 # TODO - pull all required game mods out and reapply to clean up patch file
 
 # add options
-# TODO - figure out how to progressive sword
 # TODO - add puzzleless to de-prio longer/confusing puzzles
 # TODO - add random start locations
 
 # known low prio
 # TODO - clean up game mod logging to necessities
 # TODO - clean up item/location names
-# TODO - refactor code
-# TODO - add swim as an option for getting 1/4 of temple coin
 
 # deathlink testing
 # deaths during pause seem to dissapear
@@ -83,7 +80,9 @@
 
 # bug reports
 # hotel backroom coin is accessible without breaking the pot
+# - confirmed, no idea how to fix
 # fanfares sometimes clip you into walls without a way out
+# - confirmed, not that worried because you always can respawn
 # generation breaks sometimes, unknown cause
 
 # ideas to explore