Skip to content

[🐞] modal keeps overflow:hidden on body #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wmertens opened this issue Apr 1, 2025 · 3 comments
Closed

[🐞] modal keeps overflow:hidden on body #1060

wmertens opened this issue Apr 1, 2025 · 3 comments
Labels
STATUS-1: needs triage This doesn't seem right TYPE: bug Something isn't working

Comments

@wmertens
Copy link
Contributor

wmertens commented Apr 1, 2025

Which package is affected?

Headless Kit

Describe the bug

can't scroll after closing search on qwik.dev

Reproduction

QwikDev/qwik#7471

Steps to reproduce

No response

System Info

web

Additional Information

No response
@wmertens wmertens added STATUS-1: needs triage This doesn't seem right TYPE: bug Something isn't working labels Apr 1, 2025
@maiieul
Copy link
Contributor

maiieul commented Apr 4, 2025

Ah yes I think I've had it a few times on qwik-ui as well on mobile. cc @thejackshelton

Could be a race condition maybe 🤔

@thejackshelton
Copy link
Collaborator

https://github.com/thejackshelton/modal-lock-repro

I was able to reproduce

@thejackshelton
Copy link
Collaborator

#1061

Ok this is the fix, it's late heading to bed. Feel free to do a new release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
STATUS-1: needs triage This doesn't seem right TYPE: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wmertens @maiieul @thejackshelton