feat: allow to customize nodeports #138
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
any update on this ? |
Contributor
|
Hi @fredleger |
Author
|
Yes the use case is to deploy in kubernetes on-premise where there is no LBs and we want to use internals ips and ports |
guilload
reviewed
Nov 6, 2025
| targetPort: grpc | ||
| name: grpc | ||
| {{- if and (or (eq (.Values.searcher.serviceType | default .Values.service.type) "NodePort") (eq .Values.service.type "NodePort")) .Values.searcher.grpcNodePort }} | ||
| nodePort: {{ .Values.searcher.restNodePort }} |
Member
There was a problem hiding this comment.
Suggested change
| nodePort: {{ .Values.searcher.restNodePort }} | |
| nodePort: {{ .Values.searcher.grpcNodePort }} |
| targetPort: rest | ||
| protocol: TCP | ||
| name: rest | ||
| {{- if and (or (eq (.Values.searcher.serviceType | default .Values.service.type) "NodePort") (eq .Values.service.type "NodePort")) .Values.searcher.restNodePort }} |
Member
There was a problem hiding this comment.
Can we break this down so it's easier to read?
{{- $type := .Values.indexer.serviceType | default .Values.service.type }}
{{- if and (eq $type "NodePort") .Values.indexer.restNodePort }}
nodePort: {{ .Values.indexer.restNodePort }}
{{- end }}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow to customize NodePorts used by quickwit services (searcher, indexer, metastore and control_plane only)
I did not add default values as it was not the case for the other values provided by the original chart (like .values.searcher.serviceType) and followed the same logic for documentation of values. Maybe this should be done more globally in another PR.