Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Include port and Adjust scheme for localhost in NIP96 json api_url #31

Open
eyemono-moe opened this issue Nov 8, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@eyemono-moe
Copy link

Currently, the api_url in NIP96 json and the nip94_event URLs do not include the port specified in the configuration file. As a result:

  • When running nostrcheck-server on localhost:3000, the URLs are set to https://localhost/***, which doesn’t allow proper access.
  • Additionally, even if the host is set to localhost, the URLs are forced to use https, which can be incompatible with local testing environments.

Feature Request

  1. Port inclusion: I would like the URL to include the port specified in the nostrcheck-server configuration file.
  2. Localhost Scheme Adjustment: When the server is configured to run on localhost, the URLs should use http instead of https.

Although unnecessary for deployment, this change would greatly assist development and testing in local environments.

@quentintaranpino quentintaranpino self-assigned this Nov 15, 2024
@quentintaranpino quentintaranpino added the enhancement New feature or request label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants