-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows CI Errors on Package Re-build #217
Comments
I re-ran the check on this repo and it passes https://github.com/quarto-dev/quarto-r/actions/runs/11798002514 We do use quarto-r/.github/workflows/R-CMD-check.yaml Lines 68 to 72 in 0fcb998
And this is because of an "issue" in R I would say where an engine is registered to be used in R CMD Check only if the package is installed. However, the issue you get in CI does not seem to be related to the quarto vignette engine not being registered... So I think what happens is that the package I wonder if I can detect the information, and pass it to the vignette engine when this is run in R CMD check context... 🤔 |
It seems R CMD build will use a lib dir in a temporary folder and install package there It seems I would need to use But it seems to be undocumented environment variable, so maybe this should not be used directly. 🤔 |
Though it is setting I'll check that first. |
This is happening for me in Github Actions which fails for my hockeystick package where I just added a Quarto vignette. this only happens on Windows, ubuntu and macos are fine. Run r-lib/actions/check-r-package@v2
|
@cortinah and anyone else; the interim fix would be to modify the - uses: r-lib/actions/setup-r-dependencies@v2
with:
# Force install the package itself
extra-packages: any::rcmdcheck, local::.
needs: check |
Thank you very much -- that fixed the Github Actions error on Windows. |
I jump into this conversation because we were having the same issue and fixed the Windows CI with this thread. The pkgdown GHA though remains an issue (permaverse/flipr#25). I just wanted to point out that in some R package repo, there are Quarto vignettes and the pkgdown GHA runs smoothly, as in https://github.com/jolars/qualpalr. I could not spot what makes it actually work but maybe it can help you guys narrow it down. Hope that helps. |
So I tried something with #228 and it seems it does not help This would confirm the problem is much more complex, and setting I still need to investigate what is the problem. Setting |
Thanks @cderv for looking into this! You suggests that also setting |
@astamm I couldn't reproduce on pkgdown the problem. I tested with https://github.com/cderv/pkgdown.quarto.issue and it passes. The .qmd vignette is built. This is the same for pkgdown issue, where not reproduction was able to be found However, they did try something there and fix doing the following Though I am unsure it fixes something; Does your flipr package still have the problem for pkgdown ? |
Yes, still seeing: Error in `quarto::quarto_render()`:
✖ Error running quarto cli.
ℹ Rerun with `quiet = FALSE` to see the full error message.
Caused by error:
! System command 'quarto' failed Details here: https://github.com/permaverse/flipr/actions/runs/13627243517/job/38898623580. |
Ok. Cryptic error as I can reproduce and yes using I'll fork you and try with your package. Thanks for sharing BTW, #228 should solve the issue so if you use it for your CI run, it should work. (unless you have other issues in vignette) |
Windows CI fails during vignette creation step of
R CMD check
, while macOS and Ubuntu CI builds pass. Pre-building the package locally resolves the issue across all platforms. Further, addinglocal::.
undersetup-r-dependencies
resolves the issue on the Windows CI; but, I don't think that's an optimal solution.Build reference:
https://github.com/stanford-stats290/netid-package/actions/runs/11763068834/job/32766629444
Windows CI Check log
The text was updated successfully, but these errors were encountered: