Skip to content

Commit 80955c1

Browse files
committed
Sync working groups
1 parent 989e1d6 commit 80955c1

File tree

1 file changed

+25
-25
lines changed

1 file changed

+25
-25
lines changed

_data/wg.yaml

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,30 @@
11
---
22
working-groups:
3+
- title: "Test classloading"
4+
board-url: "https://github.com/orgs/quarkusio/projects/30"
5+
short-description: The goal of this working group is to rewrite Quarkus's test classloading, so that tests are run in the same classloader as the application under tests, and Quarkus extensions can do "Quarkus-y" manipulations of test classes.
6+
readme: |
7+
<p>At the moment, Quarkus tests are invoked using one classloader, and then executed in a different classloader. This mostly works well, but means some use cases don't work: extensions cannot manipulate test classes in the same way that they do normal application classes. For example, anything run via a JUnit @TestTemplate test case will see the un-transformed class.</p>
8+
<p>It also means we have extra user-facing complexity, such as the QuarkusTest*Callbacks](https://quarkus.io/guides/getting-started-testing#enrichment-via-quarkustestcallback):</p>
9+
<blockquote>
10+
<p>While it is possible to use JUnit Jupiter callback interfaces like BeforeEachCallback, you might run into classloading issues because Quarkus has to run tests in a custom classloader which JUnit is not aware of.</p>
11+
</blockquote>
12+
<p>A final benefit is a reduction in the internal complexity of our code. Hopping between classloaders during test execution takes a lot of work, and adds a lot of code! It also is brittle in places. For example, because the hop between classloaders relies on serialization in some cases, it's becoming harder to do as the JVM tightens up security restrictions. We used to rely on xstream, but that stopped working in Java 17. In https://github.com/quarkusio/quarkus/pull/40601, @dmlloyd moved us to use the JBoss Serializer, which works better, but might still be affected by future restrictions on class access.</p>
13+
<p>The goal of this working group is to allow test classes to fully participate in the 'quarkification' of classes. The mechanism for this is probably just to load the test classes with the classloader we intend to run them with, so that JUnit sees the 'correct' version of the class.</p>
14+
<ul>
15+
<li>Point of contact: @holly-cummins (@<strong>Holly Cummins</strong> on Zulip)</li>
16+
<li>Proposal: https://github.com/quarkusio/quarkus/discussions/41867</li>
17+
<li>Discussion: <a href="https://quarkusio.zulipchat.com/#narrow/channel/187038-dev/topic/WG.20.2330.20Test.20Classloading.20chatter/">Zulip topic</a></li>
18+
</ul>
19+
status: on track
20+
completed: false
21+
last-activity: 2025-03-20
22+
last-update-date: 2025-03-03
23+
last-update: |
24+
Code cleanup underway to remove TODOs and the most egregious hacks. CI is (mostly, sometimes) green: https://github.com/quarkusio/quarkus/actions/runs/13628335866/job/38090976898
25+
point-of-contact: "@holly-cummins (@<strong>Holly Cummins</strong> on Zulip)"
26+
proposal: https://github.com/quarkusio/quarkus/discussions/41867
27+
discussion: https://quarkusio.zulipchat.com/#narrow/channel/187038-dev/topic/WG.20.2330.20Test.20Classloading.20chatter/
328
- title: "Gizmo 2"
429
board-url: "https://github.com/orgs/quarkusio/projects/43"
530
short-description: Gizmo 2 related tasks
@@ -66,31 +91,6 @@ working-groups:
6691
Everything is fine for now.
6792
6893
There are discussions on defining a regular cadence release. We will communicate when we have more details.
69-
- title: "Test classloading"
70-
board-url: "https://github.com/orgs/quarkusio/projects/30"
71-
short-description: The goal of this working group is to rewrite Quarkus's test classloading, so that tests are run in the same classloader as the application under tests, and Quarkus extensions can do "Quarkus-y" manipulations of test classes.
72-
readme: |
73-
<p>At the moment, Quarkus tests are invoked using one classloader, and then executed in a different classloader. This mostly works well, but means some use cases don't work: extensions cannot manipulate test classes in the same way that they do normal application classes. For example, anything run via a JUnit @TestTemplate test case will see the un-transformed class.</p>
74-
<p>It also means we have extra user-facing complexity, such as the QuarkusTest*Callbacks](https://quarkus.io/guides/getting-started-testing#enrichment-via-quarkustestcallback):</p>
75-
<blockquote>
76-
<p>While it is possible to use JUnit Jupiter callback interfaces like BeforeEachCallback, you might run into classloading issues because Quarkus has to run tests in a custom classloader which JUnit is not aware of.</p>
77-
</blockquote>
78-
<p>A final benefit is a reduction in the internal complexity of our code. Hopping between classloaders during test execution takes a lot of work, and adds a lot of code! It also is brittle in places. For example, because the hop between classloaders relies on serialization in some cases, it's becoming harder to do as the JVM tightens up security restrictions. We used to rely on xstream, but that stopped working in Java 17. In https://github.com/quarkusio/quarkus/pull/40601, @dmlloyd moved us to use the JBoss Serializer, which works better, but might still be affected by future restrictions on class access.</p>
79-
<p>The goal of this working group is to allow test classes to fully participate in the 'quarkification' of classes. The mechanism for this is probably just to load the test classes with the classloader we intend to run them with, so that JUnit sees the 'correct' version of the class.</p>
80-
<ul>
81-
<li>Point of contact: @holly-cummins (@<strong>Holly Cummins</strong> on Zulip)</li>
82-
<li>Proposal: https://github.com/quarkusio/quarkus/discussions/41867</li>
83-
<li>Discussion: <a href="https://quarkusio.zulipchat.com/#narrow/channel/187038-dev/topic/WG.20.2330.20Test.20Classloading.20chatter/">Zulip topic</a></li>
84-
</ul>
85-
status: on track
86-
completed: false
87-
last-activity: 2025-03-14
88-
last-update-date: 2025-03-03
89-
last-update: |
90-
Code cleanup underway to remove TODOs and the most egregious hacks. CI is (mostly, sometimes) green: https://github.com/quarkusio/quarkus/actions/runs/13628335866/job/38090976898
91-
point-of-contact: "@holly-cummins (@<strong>Holly Cummins</strong> on Zulip)"
92-
proposal: https://github.com/quarkusio/quarkus/discussions/41867
93-
discussion: https://quarkusio.zulipchat.com/#narrow/channel/187038-dev/topic/WG.20.2330.20Test.20Classloading.20chatter/
9494
- title: "Observability.Next"
9595
board-url: "https://github.com/orgs/quarkusio/projects/42"
9696
short-description: Observability.Next is a strategic initiative to modernize the observability stack within the Quarkus framework, aiming to streamline and enhance its ability to monitor and manage distributed systems.

0 commit comments

Comments
 (0)