Merge pull request #50669 from matejvasek/fixes-funqy

Better error message for Funq when using `Byte[]` instead of `byte[]`

Author: geoand

extensions/funqy/funqy-knative-events/deployment/src/test/java/io/quarkus/funqy/test/BadBinaryArrayTest.java

@@ -0,0 +1,57 @@
+package io.quarkus.funqy.test;
+
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assertions.fail;
+
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.RegisterExtension;
+
+import io.quarkus.test.QuarkusUnitTest;
+
+public class BadBinaryArrayTest {
+    @RegisterExtension
+    static QuarkusUnitTest test1 = assertException(BadBinaryOutputCE.class);
+    @RegisterExtension
+    static QuarkusUnitTest test2 = assertException(BadBinaryOutputRaw.class);
+    @RegisterExtension
+    static QuarkusUnitTest test3 = assertException(BadBinaryInputCE.class);
+    @RegisterExtension
+    static QuarkusUnitTest test4 = assertException(BadBinaryInputRaw.class);
+
+    private static QuarkusUnitTest assertException(Class<?> clazz) {
+        return new QuarkusUnitTest()
+                .withApplicationRoot(jar -> jar.addClass(clazz))
+                .assertException(throwable -> {
+                    // Traverse the cause chain to find the IllegalStateException
+                    Throwable current = throwable;
+                    IllegalStateException foundException = null;
+
+                    while (current != null) {
+                        if (current instanceof IllegalStateException) {
+                            foundException = (IllegalStateException) current;
+                            break;
+                        }
+                        current = current.getCause();
+                    }
+
+                    if (foundException == null) {
+                        fail("Expected IllegalStateException but got: " + throwable);
+                    }
+
+                    String message = foundException.getMessage();
+                    if (message == null) {
+                        fail("Exception message is null");
+                    }
+
+                    // Verify the exception message mentions the issue with Byte[] vs byte[]
+                    if (!message.contains("Byte[]") || !message.contains("byte[]")) {
+                        fail("Exception message should mention both 'Byte[]' and 'byte[]'. Got: " + message);
+                    }
+                });
+    }
+
+    @Test
+    void test() {
+        assertTrue(true);
+    }
+}

extensions/funqy/funqy-knative-events/deployment/src/test/java/io/quarkus/funqy/test/BadBinaryInputCE.java

@@ -0,0 +1,12 @@
+package io.quarkus.funqy.test;
+
+import io.quarkus.funqy.Funq;
+import io.quarkus.funqy.knative.events.CloudEvent;
+import io.quarkus.funqy.knative.events.CloudEventMapping;
+
+public class BadBinaryInputCE {
+    @Funq
+    @CloudEventMapping(trigger = "test-bad-input-ce")
+    public void badInputCE(CloudEvent<Byte[]> data) {
+    }
+}

extensions/funqy/funqy-knative-events/deployment/src/test/java/io/quarkus/funqy/test/BadBinaryInputRaw.java

@@ -0,0 +1,11 @@
+package io.quarkus.funqy.test;
+
+import io.quarkus.funqy.Funq;
+import io.quarkus.funqy.knative.events.CloudEventMapping;
+
+public class BadBinaryInputRaw {
+    @Funq
+    @CloudEventMapping(trigger = "test-bad-input-raw")
+    public void badInputRaw(Byte[] data) {
+    }
+}

extensions/funqy/funqy-knative-events/deployment/src/test/java/io/quarkus/funqy/test/BadBinaryOutputCE.java

@@ -0,0 +1,19 @@
+package io.quarkus.funqy.test;
+
+import io.quarkus.funqy.Funq;
+import io.quarkus.funqy.knative.events.CloudEvent;
+import io.quarkus.funqy.knative.events.CloudEventBuilder;
+import io.quarkus.funqy.knative.events.CloudEventMapping;
+
+public class BadBinaryOutputCE {
+    @Funq
+    @CloudEventMapping(trigger = "test-bad-output-ce")
+    public CloudEvent<Byte[]> badOutputCE() {
+        return CloudEventBuilder.create()
+                .specVersion("1.0")
+                .id("test-bad-output-ce")
+                .type("badOutputCE")
+                .source("/badOutputCE")
+                .build(new Byte[] {});
+    }
+}

extensions/funqy/funqy-knative-events/deployment/src/test/java/io/quarkus/funqy/test/BadBinaryOutputRaw.java

@@ -0,0 +1,12 @@
+package io.quarkus.funqy.test;
+
+import io.quarkus.funqy.Funq;
+import io.quarkus.funqy.knative.events.CloudEventMapping;
+
+public class BadBinaryOutputRaw {
+    @Funq
+    @CloudEventMapping(trigger = "test-bad-output-raw")
+    public Byte[] badOutputRaw() {
+        return new Byte[] {};
+    }
+}

extensions/funqy/funqy-knative-events/runtime/src/main/java/io/quarkus/funqy/runtime/bindings/knative/events/KnativeEventsBindingRecorder.java

@@ -127,6 +127,8 @@ public void init() {
                     }
                 }
 
+                validateNotBoxedByteArray(inputType, invoker.getName(), "input");
+
                 JavaType javaInputType = objectMapper.constructType(inputType);
                 ObjectReader reader = objectMapper.readerFor(javaInputType);
                 invoker.getBindingContext().put(DATA_OBJECT_READER, reader);
@@ -148,6 +150,8 @@ public void init() {
                     }
                 }
 
+                validateNotBoxedByteArray(outputType, invoker.getName(), "output");
+
                 JavaType outputJavaType = objectMapper.constructType(outputType);
                 ObjectWriter writer = objectMapper.writerFor(outputJavaType);
                 invoker.getBindingContext().put(DATA_OBJECT_WRITER, writer);
@@ -278,4 +282,17 @@ private boolean hasSameFilters(String name, List<Predicate<CloudEvent>> one, Lis
         }
         return result;
     }
+
+    private void validateNotBoxedByteArray(Type type, String functionName, String paramType) {
+        Class<?> rawType = Reflections.getRawType(type);
+        if (rawType != null && rawType.isArray()) {
+            Class<?> componentType = rawType.getComponentType();
+            if (Byte.class.equals(componentType)) {
+                throw new IllegalStateException(
+                        "Function '" + functionName + "' has " + paramType + " type 'Byte[]' (boxed byte array). " +
+                                "Use 'byte[]' (primitive byte array) instead. " +
+                                "Byte[] is not supported for binary data handling in Funqy Knative Events.");
+            }
+        }
+    }
 }