We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
2 parents e915edf + b8c0ebd commit cfdf82aCopy full SHA for cfdf82a
pyfolio/timeseries.py
@@ -890,7 +890,7 @@ def get_max_drawdown_underwater(underwater):
890
The maximum drawdown's recovery.
891
"""
892
893
- valley = np.argmin(underwater) # end of the period
+ valley = underwater.idxmin() # end of the period
894
# Find first 0
895
peak = underwater[:valley][underwater[:valley] == 0].index[-1]
896
# Find last 0
@@ -963,7 +963,7 @@ def get_top_drawdowns(returns, top=10):
963
underwater = underwater.loc[:peak]
964
965
drawdowns.append((peak, valley, recovery))
966
- if (len(returns) == 0) or (len(underwater) == 0):
+ if (len(returns) == 0) or (len(underwater) == 0) or (np.min(underwater) == 0):
967
break
968
969
return drawdowns
0 commit comments