Skip to content

Commit cfdf82a

Browse files
authored
Merge pull request #634 from Ildhesten/master
Fixes in drawdown table when using latest version of pandas
2 parents e915edf + b8c0ebd commit cfdf82a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

pyfolio/timeseries.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -890,7 +890,7 @@ def get_max_drawdown_underwater(underwater):
890890
The maximum drawdown's recovery.
891891
"""
892892

893-
valley = np.argmin(underwater) # end of the period
893+
valley = underwater.idxmin() # end of the period
894894
# Find first 0
895895
peak = underwater[:valley][underwater[:valley] == 0].index[-1]
896896
# Find last 0
@@ -963,7 +963,7 @@ def get_top_drawdowns(returns, top=10):
963963
underwater = underwater.loc[:peak]
964964

965965
drawdowns.append((peak, valley, recovery))
966-
if (len(returns) == 0) or (len(underwater) == 0):
966+
if (len(returns) == 0) or (len(underwater) == 0) or (np.min(underwater) == 0):
967967
break
968968

969969
return drawdowns

0 commit comments

Comments
 (0)