fix #234

kind of a hack but it works for this edge case
quantizor · Mar 18, 2019 · d815885 · d815885
1 parent 544845c
commit d815885
Show file tree

Hide file tree

Showing 2 changed files with 112 additions and 4 deletions.
diff --git a/index.compiler.spec.js b/index.compiler.spec.js
@@ -101,6 +101,114 @@ it('#190 perf regression', () => {
 `);
 });
 
+it('#234 perf regression', () => {
+  render(
+    compiler(
+      `<br /><b>1</b><b>2</b><b>3</b><b>4</b><b>5</b><b>6</b><b>7</b><b>8</b><b>9</b><b>10</b>
+<b>1</b><b>2</b><b>3</b><b>4</b><b>5</b><b>6</b><b>7</b><b>8</b><b>9</b><b>20</b>
+<b>1</b><b>2</b><b>3</b><b>4</b><b>5</b><b>6</b><b>7</b><b>8</b><b>9</b><b>30</b>`
+    )
+  );
+
+  expect(root.innerHTML).toMatchInlineSnapshot(`
+
+<div data-reactroot>
+  <br>
+  <b>
+    1
+  </b>
+  <b>
+    2
+  </b>
+  <b>
+    3
+  </b>
+  <b>
+    4
+  </b>
+  <b>
+    5
+  </b>
+  <b>
+    6
+  </b>
+  <b>
+    7
+  </b>
+  <b>
+    8
+  </b>
+  <b>
+    9
+  </b>
+  <b>
+    10
+  </b>
+  <b>
+    1
+  </b>
+  <b>
+    2
+  </b>
+  <b>
+    3
+  </b>
+  <b>
+    4
+  </b>
+  <b>
+    5
+  </b>
+  <b>
+    6
+  </b>
+  <b>
+    7
+  </b>
+  <b>
+    8
+  </b>
+  <b>
+    9
+  </b>
+  <b>
+    20
+  </b>
+  <b>
+    1
+  </b>
+  <b>
+    2
+  </b>
+  <b>
+    3
+  </b>
+  <b>
+    4
+  </b>
+  <b>
+    5
+  </b>
+  <b>
+    6
+  </b>
+  <b>
+    7
+  </b>
+  <b>
+    8
+  </b>
+  <b>
+    9
+  </b>
+  <b>
+    30
+  </b>
+</div>
+
+`);
+});
+
 describe('inline textual elements', () => {
   it('should handle emphasized text', () => {
     render(compiler('*Hello.*'));
@@ -2845,14 +2953,14 @@ describe('overrides', () => {
   it('should override the title property when parsing a link', () => {
     class FakeLink extends React.Component {
       render() {
-        const {title, children} = this.props
-        return <a title={title}>{children}</a>
+        const { title, children } = this.props;
+        return <a title={title}>{children}</a>;
       }
     }
 
     render(
       compiler('[link](https://example.org)', {
-        overrides: { a: {component: FakeLink,  props: { title: 'foo' } } },
+        overrides: { a: { component: FakeLink, props: { title: 'foo' } } },
       })
     );
 

diff --git a/index.js b/index.js
@@ -140,7 +140,7 @@ const HEADING_SETEXT_R = /^([^\n]+)\n *(=|-){3,} *(?:\n *)+\n/;
  * 6. Capture excess newlines afterward
  *    \n*
  */
-const HTML_BLOCK_ELEMENT_R = /^ *<([A-Za-z][^ >/]*) ?([^>]*)\/{0}>\n?(\s*(?:<\1[^>]*?>[\s\S]*?<\/\1>|(?!<\1)[\s\S])*?)<\/\1>\n*/;
+const HTML_BLOCK_ELEMENT_R = /^ *(?!<[a-z][^ >/]* ?\/>)<([a-z][^ >/]*) ?([^>]*)\/{0}>\n?(\s*(?:<\1[^>]*?>[\s\S]*?<\/\1>|(?!<\1)[\s\S])*?)<\/\1>\n*/i;
 
 const HTML_CHAR_CODE_R = /&([a-z]+);/g;