Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Makefile object names for targets: gfortran, intel-seq #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chstan
Copy link

@chstan chstan commented Mar 11, 2020

In compiling (initially for Windows and subsequently for Ubuntu with the gfortran toolchain) I ran into this issue where compilation fails because make is treating the targets in a case sensitive way.

I've updated the Makefiles for all targets so they refer to the $(OBJ) with the same case (all caps) as the designated target.

For others in the future, this manifested as an error in the linker because no object files were being built:

gfortran in function _start' (.text+0x20) undefined reference to main'

@codecov-io
Copy link

Codecov Report

Merging #65 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #65   +/-   ##
=======================================
  Coverage   31.72%   31.72%           
=======================================
  Files          36       36           
  Lines       13777    13777           
=======================================
  Hits         4371     4371           
  Misses       9406     9406

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfc9756...12222a8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants