Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis options overridden by default options #97

Closed
yaelbh opened this issue Jun 10, 2021 · 1 comment
Closed

Analysis options overridden by default options #97

yaelbh opened this issue Jun 10, 2021 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@yaelbh
Copy link
Collaborator

yaelbh commented Jun 10, 2021

Still need to verify that there is really a bug here. It looks like this from the following lines, taken from BaseAnalysis.run:

        analysis_options = self._default_options()
        analysis_options.update_options(**options)

I see two potential issues here:

  • The first line retrieves the default options instead of the current ones, hence overriding the current options by the default ones.
  • Possibly the second line overrides the default options.
@yaelbh yaelbh added the bug Something isn't working label Jun 10, 2021
@yaelbh yaelbh added this to the Release 0.1 milestone Jun 21, 2021
@yaelbh
Copy link
Collaborator Author

yaelbh commented Jun 21, 2021

Closing because it was fixed, apparently in #39

@yaelbh yaelbh closed this as completed Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant