Skip to content

Remove "BLANK" string checking to id blanks in SPP #140

@AmandaBirmingham

Description

@AmandaBirmingham

Some places in the SPP still identify blanks by looking for the string "BLANK" at the beginning of the sample name, which is is inconsistent with how it is being done in kl-metapool for modern sample sheets (which use the SampleContext section) and is going to break if we try to implement katharoseq (or any other kind of non-extraction) blanks.

I've managed to get rid of most of the ones that are in the shotgun processing, but a couple remain because they are in code that is shared between both amplicon and shotgun. I haven't dealt with ANY of the ones in amplicon-specific processing.

The shared ones I know about are in Assay._replace_tube_ids_w_sample_names:

sample_name = df.at[i, "sample_name"]
# blanks do not get their names swapped.
if sample_name.startswith('BLANK'):

... and in Workflow._compare_samples_against_qiita:

# do not include BLANKs. If they are unregistered, we will add
# them downstream.
samples = {smpl for smpl in samples
if not smpl.startswith('BLANK')}

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions