We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi Quest,
As part of reading through many docs I just noticed a potential issue you might have. UnmarshalJSON is supposed to be a no-op when it encounters null.
null
https://golang.org/pkg/encoding/json/#Unmarshaler
By convention, to approximate the behavior of Unmarshal itself, Unmarshalers implement UnmarshalJSON([]byte("null")) as a no-op.
See second part after || of this line. I believe it should be removed or at least noted. https://github.com/qhenkart/objectid-go/blob/master/objectid.go#L155
||
Was very hidden in std lib docs. Think I have to fix a spot or two in my projects also.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Hi Quest,
As part of reading through many docs I just noticed a potential issue you might have. UnmarshalJSON is supposed to be a no-op when it encounters
null.https://golang.org/pkg/encoding/json/#Unmarshaler
See second part after
||of this line. I believe it should be removed or at least noted.https://github.com/qhenkart/objectid-go/blob/master/objectid.go#L155
Was very hidden in std lib docs. Think I have to fix a spot or two in my projects also.
The text was updated successfully, but these errors were encountered: