Skip to content

Define CpuDevice class and move CPU specific methods (color conversion) to it #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dvrogozh opened this issue Apr 4, 2025 · 0 comments · May be fixed by #636
Open

Define CpuDevice class and move CPU specific methods (color conversion) to it #619

dvrogozh opened this issue Apr 4, 2025 · 0 comments · May be fixed by #636

Comments

@dvrogozh
Copy link
Contributor

dvrogozh commented Apr 4, 2025

As discussed in:

A follow up after #606 - need to define CpuDevice class and move SingleStreamDecoder::*OnCPU() functions to it.

CC: @scotts, @NicolasHug
This was referenced Apr 4, 2025
Merged
Open
dvrogozh added a commit to dvrogozh/torchcodec that referenced this issue Apr 10, 2025
@dvrogozh
Define CpuDeviceInterface
cec7e9e 
Fixes: pytorch#619

* Commit defines `CpuDeviceInterface` and moves video `*OnCPU` methods
  from `SingleStreamDecoder` to it.
* Audio `*OnCPU` methods left in `SingleStreamDecoder`
* Constructor API of `DeviceInterface` was changed to allow passing
  `AVRational timeBase` required to initialize ffmpeg filter graph

Signed-off-by: Dmitry Rogozhkin <[email protected]>
@dvrogozh dvrogozh linked a pull request Apr 10, 2025 that will close this issue
Open
dvrogozh added a commit to dvrogozh/torchcodec that referenced this issue Apr 16, 2025
@dvrogozh
Define CpuDeviceInterface
467adec 
Fixes: pytorch#619

* Commit defines `CpuDeviceInterface` and moves video `*OnCPU` methods
  from `SingleStreamDecoder` to it.
* Audio `*OnCPU` methods left in `SingleStreamDecoder`
* Constructor API of `DeviceInterface` was changed to allow passing
  `AVRational timeBase` required to initialize ffmpeg filter graph

Signed-off-by: Dmitry Rogozhkin <[email protected]>
dvrogozh added a commit to dvrogozh/torchcodec that referenced this issue Apr 29, 2025
@dvrogozh
Define CpuDeviceInterface
bc9eaa7 
Fixes: pytorch#619

* Commit defines `CpuDeviceInterface` and moves video `*OnCPU` methods
  from `SingleStreamDecoder` to it.
* Audio `*OnCPU` methods left in `SingleStreamDecoder`
* Constructor API of `DeviceInterface` was changed to allow passing
  `AVRational timeBase` required to initialize ffmpeg filter graph

Signed-off-by: Dmitry Rogozhkin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Define CpuDeviceInterface dvrogozh/torchcodec
1 participant
@dvrogozh