Skip to content

Exir: Defer string creation in internal_assert - #24789

Merged
Erik-Lundell merged 4 commits into
pytorch:mainfrom
Erik-Lundell:defer-string-creation
Nov 9, 2026
Merged

Exir: Defer string creation in internal_assert#24789
Erik-Lundell merged 4 commits into
pytorch:mainfrom
Erik-Lundell:defer-string-creation

Conversation

@Erik-Lundell

@Erik-Lundell Erik-Lundell commented Nov 9, 2026 •
edited by pytorch-bot Bot
Loading

Copy link
Copy Markdown
Collaborator 
Exir: Defer string materialization in internal_assert

Make sure the string is only materialized when the
assert triggers. On one measurement, this sped up
memory planning validation of tiny_stories from 2.949 → 0.921 s.

Signed-off-by: Erik Lundell <erik.lundell@arm.com>

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

@Erik-Lundell
Exir: Defer string materialization in internal_assert
2fe7e16 
Make sure the string is only materialized when the
assert trigges. On a measurement, this sped up
validation of tiny_stories from 2.949 → 0.921 s.

Signed-off-by: Erik Lundell <erik.lundell@arm.com>
Change-Id: I90797910fd12f0a063d23bbab836145d999c55d0
@Erik-Lundell
Remove overtesting.
1aaa793 
Signed-off-by: Erik Lundell <erik.lundell@arm.com>
Change-Id: Ic10ecffcb23e6d0630a1ede250d997cc1c08fd92
@Erik-Lundell Erik-Lundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes labels Nov 9, 2026
@pytorch-bot

pytorch-bot Bot commented Nov 9, 2026 •
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24789

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Pending, 1 Unrelated Failure

As of commit e6387e9 with merge base 0fde0dd (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 9, 2026
zingo
zingo approved these changes Nov 9, 2026
View reviewed changes

@zingo zingo left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge, just make sure CI is OK, I see a lit of errors so I rebased this to make sure it not related and still there.

@Erik-Lundell
Erik-Lundell merged commit 45c091f into pytorch:main Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zingo zingo zingo approved these changes
@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner
@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Erik-Lundell @zingo