Repository navigation
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24848
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit 8630f11 with merge base 4529a94 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
JakeStevens
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Stack from ghstack (oldest at bottom):
Ulterior Motive
Running Gemma 4 31B through ExecuTorch Native's GGML engine on CUDA, to find why it decodes slower than llama.cpp on the same GGUF.
Rationale
What:
--tokenizeralso takes a Hugging Facetokenizer.json, or a directory holding one.Why: The runner loaded only Llama 3 TikToken models, and Gemma 4 ships its tokenizer as a
tokenizer.json.Details
.json, or a directory, loadstokenizers::HFTokenizer; any other path loads the Llama 3 TikToken model as before.encodeprepended--num_bosBOS tokens, at most 127.--num_boscopies of the tokenizer's BOS itself, because atokenizer.jsonadds BOS only if its post-processor does. TikToken prompts encode to the same tokens as before.llm_runnerdepends on//pytorch/tokenizers:hf_tokenizer.Authored with Claude Code.
Differential Revision: D130721992