Skip to content

Arm backend: Fix optional dtype annotation in SmolLM2 evaluation - #24833

Merged
zingo merged 1 commit into
pytorch:mainfrom
zingo:Arm-backend-Fix-optional-dtype-annotation-in-SmolLM2-evaluation
Nov 10, 2026
Merged

zingo merged 1 commit into
pytorch:mainfrom
zingo:Arm-backend-Fix-optional-dtype-annotation-in-SmolLM2-evaluation

Conversation

@zingo

@zingo zingo commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Explicitly allow None for input_dtype. Newer NumPy versions no longer include None in DTypeLike, causing mypy to reject the default value.

This changes only the annotation, not runtime behaviour.

AI-assisted-by: Codex

cc @digantdesai @freddan80 @per @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

Explicitly allow None for input_dtype. Newer NumPy versions no longer
include None in DTypeLike, causing mypy to reject the default value.

This changes only the annotation, not runtime behaviour.

AI-assisted-by: Codex

Signed-off-by: Zingo Andersen <Zingo.Andersen@arm.com>
Change-Id: If6cb76ee4828ad30cb8c17b8e901b5574788fb98
@pytorch-bot

pytorch-bot Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24833

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 3 Pending

As of commit 1560387 with merge base e34f8cf (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 10, 2026
@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Nov 10, 2026
@zingo zingo added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes labels Nov 10, 2026
@zingo

zingo commented Nov 10, 2026

Copy link
Copy Markdown
Collaborator Author

Failed tests are unrelated

@zingo
zingo merged commit ee8dc00 into pytorch:main Nov 10, 2026
456 of 462 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants