Repository navigation
Conversation
ConvertToLinearPass rebuilds linear from an [add]mm by taking the weight from before its transpose. When constant propagation or a transpose removal pass has already folded that transpose into the constant, the [add]mm reads the transposed weight directly and the rebuilt linear transposes it a second time: square weights give wrong values and other shapes make the pass fail. Only convert nodes whose weight still comes through a transpose, and leave the rest as [add]mm. Fixes pytorch#10499
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24784
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New FailuresAs of commit 605171e with merge base e0015e1 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @sohailshk! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
|
meta-cla
Bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
executorch-triage
Bot
added
the
community: contribution
|
@mcr229 @digantdesai @metascroy @JakeStevens bringing this to your attention |
nil-is-all
added
module: xnnpack
ConvertToLinearPass rebuilds linear from an [add]mm by taking the weight from before its transpose. When constant propagation or a transpose removal pass has already folded that transpose into the constant, the [add]mm reads the transposed weight directly and the rebuilt linear transposes it a second time: square weights give wrong values and other shapes make the pass fail. Only convert nodes whose weight still comes through a transpose, and leave the rest as [add]mm.
Fixes #10499
cc @GregoryComer @digantdesai @cbilgin @JakeStevens @nil-is-all