Skip to content

Commit a9e265f

Browse files
authored
Remove unused broadcast_util include and dep for op__to_dim_order_copy (#14323)
### Summary `op__to_dim_order_copy` no longer requires `broadcast_util`. In the process of implementing [clone_dim_order](#12974), the helper function `_to_dim_order_copy_impl` was moved from [op__to_dim_order_copy.cpp](https://github.com/pytorch/executorch/pull/12974/files/06c38ad587c463a360eaed1c2582a9a9dca7bbe6#diff-4f7616dde078e699c95824f2e5446bf4f47ffa53cac140e13ec84cf2065ab294L32) into [copy_ops_util.h](https://github.com/pytorch/executorch/pull/12974/files/06c38ad587c463a360eaed1c2582a9a9dca7bbe6). The only reason `broadcast_util` was needed was to support that helper, so it can now be dropped from `op__to_dim_order_copy`. ### Test plan Enabled `op__to_dim_order_copy_test` in [kernel test CMakeLists.txt](https://github.com/pytorch/executorch/blob/4a4f5a034b6cda395abe7b6aa13b8066b776ffb2/kernels/test/CMakeLists.txt#L289) All tests passed via: `./build-ninja/kernels/test/portable_kernels_test --gtest_filter='OpToDimOrderCopyTest.*'` cc @Gasoonjia
1 parent b80ac3b commit a9e265f

File tree

2 files changed

+0
-2
lines changed

2 files changed

+0
-2
lines changed

kernels/portable/cpu/op__to_dim_order_copy.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
#include <c10/util/irange.h>
1010

1111
#include <executorch/kernels/portable/cpu/scalar_utils.h>
12-
#include <executorch/kernels/portable/cpu/util/broadcast_util.h>
1312
#include <executorch/kernels/portable/cpu/util/copy_ops_util.h>
1413
#include <executorch/runtime/kernel/kernel_includes.h>
1514

shim_et/xplat/executorch/kernels/portable/op_registration_util.bzl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1342,7 +1342,6 @@ ATEN_OPS = (
13421342
name = "op__to_dim_order_copy",
13431343
deps = [
13441344
":scalar_utils",
1345-
"//executorch/kernels/portable/cpu/util:broadcast_util",
13461345
"//executorch/kernels/portable/cpu/util:copy_ops_util",
13471346
],
13481347
),

0 commit comments

Comments
 (0)