Skip to content

Commit 08e7b04

Browse files
authored
Merge branch 'main' into jz/cpp-no-op-tokenizer
2 parents a536432 + cf8ce89 commit 08e7b04

File tree

5 files changed

+17
-4
lines changed

5 files changed

+17
-4
lines changed

.buckconfig

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,3 +39,6 @@
3939

4040
[buck2]
4141
restarter=true
42+
43+
[oss]
44+
folly_cxx_tests = False

.ci/scripts/unittest-buck2.sh

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,14 @@ set -eux
88

99
# TODO: expand this to //...
1010
# TODO: can't query cadence & vulkan backends
11+
# TODO: can't query //kernels/prim_ops because of a cpp_unittest and
12+
# broken code in shim to read oss.folly_cxx_tests. Sending fix but it
13+
# needs to propagate and we need a submodule update.
1114
buck2 query "//backends/apple/... + //backends/example/... + \
1215
//backends/mediatek/... + //backends/test/... + //backends/transforms/... + \
13-
//backends/xnnpack/... + //configurations/... + //kernels/portable/cpu/... + \
14-
//runtime/... + //schema/... + //test/... + //util/..."
16+
//backends/xnnpack/... + //configurations/... + //kernels/aten/... + \
17+
//kernels/optimized/... + //kernels/portable/... + //kernels/quantized/... + \
18+
//kernels/test/... + //runtime/... + //schema/... + //test/... + //util/..."
1519

1620
# TODO: expand the covered scope of Buck targets.
1721
# //runtime/kernel/... is failing because //third-party:torchgen_files's shell script can't find python on PATH.

backends/arm/test/passes/test_fuse_constant_ops_pass.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
# LICENSE file in the root directory of this source tree.
55

66
import operator
7+
import unittest
78
from typing import Tuple
89

910
import torch
@@ -107,6 +108,7 @@ def test_fuse_batchnorm_tosa_MI(module):
107108
pipeline.run()
108109

109110

111+
@unittest.skip("Test failing on internal CI")
110112
@common.parametrize("module", modules)
111113
def test_fuse_batchnorm_tosa_BI(module):
112114
pipeline = TosaPipelineBI[input_t](

backends/xnnpack/CMakeLists.txt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
# cmake-format -i CMakeLists.txt
1111
# ~~~
1212

13-
cmake_minimum_required(VERSION 3.19)
13+
cmake_minimum_required(VERSION 3.24)
1414

1515
set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
1616

@@ -124,6 +124,10 @@ else()
124124
list(APPEND xnn_executor_runner_libs portable_ops_lib)
125125
endif()
126126

127+
if(EXECUTORCH_BUILD_KERNELS_CUSTOM)
128+
list(APPEND xnn_executor_runner_libs $<LINK_LIBRARY:WHOLE_ARCHIVE,custom_ops>)
129+
endif()
130+
127131
list(APPEND xnn_executor_runner_libs xnnpack_backend executorch)
128132

129133
# ios can only build library but not binary

shim

0 commit comments

Comments
 (0)