From 6ece3fb5630f76279e844581341c44be912d4977 Mon Sep 17 00:00:00 2001
From: Adam Turner <9087854+aa-turner@users.noreply.github.com>
Date: Sat, 12 Apr 2025 19:44:51 +0100
Subject: [PATCH] Skip checking canonical links if nothing was built

---
 build_docs.py | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/build_docs.py b/build_docs.py
index 07c98ae..faa8648 100755
--- a/build_docs.py
+++ b/build_docs.py
@@ -1101,7 +1101,7 @@ def build_docs(args: argparse.Namespace) -> bool:
     switchers_content = render_switchers(versions, languages)
 
     build_succeeded = set()
-    build_failed = set()
+    any_build_failed = False
     cpython_repo = Repository(
         "https://github.com/python/cpython.git",
         args.build_root / _checkout_name(args.select_output),
@@ -1130,7 +1130,7 @@ def build_docs(args: argparse.Namespace) -> bool:
         if built_successfully:
             build_succeeded.add((version.name, language.tag))
         elif built_successfully is not None:
-            build_failed.add((version.name, language.tag))
+            any_build_failed = True
 
     logging.root.handlers[0].setFormatter(
         logging.Formatter("%(asctime)s %(levelname)s: %(message)s")
@@ -1153,11 +1153,13 @@ def build_docs(args: argparse.Namespace) -> bool:
         args.skip_cache_invalidation,
         http,
     )
-    proofread_canonicals(args.www_root, args.skip_cache_invalidation, http)
+    if build_succeeded:
+        # Only check canonicals if at least one version was built.
+        proofread_canonicals(args.www_root, args.skip_cache_invalidation, http)
 
     logging.info("Full build done (%s).", format_seconds(perf_counter() - start_time))
 
-    return len(build_failed) == 0
+    return any_build_failed
 
 
 def parse_versions_from_devguide(http: urllib3.PoolManager) -> Versions: