Skip to content

gh-121249: Deprecate using F/D type codes in the struct module#152309

Merged
vstinner merged 6 commits into
python:mainfrom
skirpichev:deprecate-FD-codes/121249
Jun 30, 2026
Merged

gh-121249: Deprecate using F/D type codes in the struct module#152309
vstinner merged 6 commits into
python:mainfrom
skirpichev:deprecate-FD-codes/121249

Conversation

@skirpichev

@skirpichev skirpichev commented Jun 26, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@skirpichev skirpichev requested a review from AA-Turner as a code owner June 26, 2026 16:06
@bedevere-app bedevere-app Bot mentioned this pull request Jun 26, 2026
Closed
@skirpichev skirpichev mentioned this pull request Jun 26, 2026
Merged
@read-the-docs-community

read-the-docs-community Bot commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33365525 | 📁 Comparing 236dab3 against main (bf61794)

  🔍 Preview build  

29 files changed · ± 28 modified · - 1 deleted

± Modified

- Deleted

vstinner
vstinner reviewed Jun 29, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO F/D formats soft deprecation should be removed from Doc/deprecations/soft-deprecations.rst, since the formats are now hard deprecated.

Comment thread Misc/NEWS.d/next/Library/2026-06-26-19-01-13.gh-issue-121249.p1SBW0.rst Outdated
Comment thread Doc/deprecations/pending-removal-in-3.21.rst Outdated
Comment thread Doc/whatsnew/3.16.rst Outdated
Comment thread Lib/test/test_struct.py Outdated
Comment thread Lib/test/test_struct.py Outdated
with self.subTest(format=f):
with warnings.catch_warnings():
warnings.simplefilter("error", DeprecationWarning)
self.assertRaises(DeprecationWarning, struct.pack, f, z)

@vstinner vstinner Jun 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already check with self.assertWarns(DeprecationWarning): below. I'm not sure that checking for DeprecationWarning exception is useful.

@skirpichev skirpichev Jun 30, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do this in other places.

Comment thread Lib/test/test_struct.py Outdated
Comment thread Doc/whatsnew/3.16.rst
skirpichev and others added 2 commits June 30, 2026 03:04
@skirpichev @vstinner
Apply suggestions from code review
87d0ea7 
Co-authored-by: Victor Stinner <vstinner@python.org>
@skirpichev
address review
a2c5ff8
@skirpichev

skirpichev commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

IMO F/D formats soft deprecation should be removed from Doc/deprecations/soft-deprecations.rst, since the formats are now hard deprecated.

Sure, I completely forgot that file. Done, with other requested changes.

vstinner
vstinner approved these changes Jun 30, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner merged commit 40795f2 into python:main Jun 30, 2026
58 checks passed
@vstinner

vstinner commented Jun 30, 2026

Copy link
Copy Markdown
Member

Merged, thanks.

@skirpichev skirpichev deleted the deprecate-FD-codes/121249 branch June 30, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skirpichev @vstinner