Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New compute-changes.py should be checked with mypy #129707

Closed
sobolevn opened this issue Feb 5, 2025 · 0 comments
Closed

New compute-changes.py should be checked with mypy #129707

sobolevn opened this issue Feb 5, 2025 · 0 comments
Assignees
@sobolevn
Labels
build The build process and cross-build type-feature A feature request or enhancement

Comments

@sobolevn
Copy link
Member

sobolevn commented Feb 5, 2025 •
edited by bedevere-app bot
Loading

Feature or enhancement

Right now we have a special mypy.ini in Tools/build:

cpython/Tools/build/mypy.ini

Line 2 in cdcacec

files = Tools/build/generate_sbom.py

But, it only checks one file. Since newly added https://github.com/python/cpython/blob/main/Tools/build/compute-changes.py is fully annotated, it should be included as well.

Refs #129627

I will send a PR.

Linked PRs
@sobolevn sobolevn added build The build process and cross-build type-feature A feature request or enhancement labels Feb 5, 2025
@sobolevn sobolevn self-assigned this Feb 5, 2025
sobolevn added a commit to sobolevn/cpython that referenced this issue Feb 5, 2025
@sobolevn
pythongh-129707: Check Tools/build/compute-changes.py with mypy
9df9a98
@bedevere-app bedevere-app bot mentioned this issue Feb 5, 2025
Merged
AA-Turner added a commit that referenced this issue Feb 6, 2025
@sobolevn @AA-Turner @hugovk
gh-129707: Check Tools/build/compute-changes.py with mypy (#129708)
8b2fb62 
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Feb 7, 2025
@sobolevn @AA-Turner
@hugovk @srinivasreddy
pythongh-129707: Check Tools/build/compute-changes.py with mypy (p…
cea3635 
…ython#129708)

Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
cmaloney pushed a commit to cmaloney/cpython that referenced this issue Feb 8, 2025
@sobolevn @AA-Turner
@hugovk @cmaloney
pythongh-129707: Check Tools/build/compute-changes.py with mypy (p…
37ad7c5 
…ython#129708)

Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
build The build process and cross-build type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sobolevn @AA-Turner