Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCC style fallthrough attribute is used with clang versions that don't support it #128902

Open
jmroot opened this issue Jan 16, 2025 · 1 comment
Open

GCC style fallthrough attribute is used with clang versions that don't support it #128902

jmroot opened this issue Jan 16, 2025 · 1 comment
Labels
3.14 new features, bugs and security fixes build The build process and cross-build type-bug An unexpected behavior, bug, or error

Comments

@jmroot
Copy link
Contributor

jmroot commented Jan 16, 2025 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

Include/pyport.h currently only guards use of __attribute__((fallthrough)) with _Py__has_attribute(fallthrough). Clang versions prior to 10 do not support this syntax, but do claim to support the fallthrough attribute (because they support the C++11 style [[fallthrough]]).

CPython versions tested on:

3.14

Operating systems tested on:

macOS

Linked PRs
@jmroot jmroot added the type-bug An unexpected behavior, bug, or error label Jan 16, 2025
@bedevere-app bedevere-app bot mentioned this issue Jan 16, 2025
Open
@ZeroIntensity ZeroIntensity added build The build process and cross-build 3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes and removed 3.12 bugs and security fixes 3.13 bugs and security fixes labels Jan 16, 2025
@ZeroIntensity
Copy link
Member

Looks like this was done in #121044

cc @sobolevn @vstinner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.14 new features, bugs and security fixes build The build process and cross-build type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmroot @ZeroIntensity