Skip to content

Bitcoin Testnet Address #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bert2002 opened this issue Sep 27, 2024 · 5 comments
Closed

Bitcoin Testnet Address #404

bert2002 opened this issue Sep 27, 2024 · 5 comments
Assignees
@msamsami
Labels
enhancement Issue/PR: A new feature

Comments

@bert2002
Copy link

Hi,
I noticed that bitcoin testnet addresses (e.g. tb1qlw09ycnp3qgqw9alqgx93ed7cg5kmnyud326ky) does not pass the check. Is there a plan to add them as well?

Thanks,
bert
@yozachar
Copy link
Collaborator

@msamsami can I assign you this?

@msamsami
Copy link
Contributor

We may not want to include support for testnet addresses. Even if we decide to, we should make sure that they are handled by separate validators to avoid conflicts with mainnet addresses.

@yozachar yozachar added the enhancement Issue/PR: A new feature label Oct 1, 2024
@msamsami
Copy link
Contributor

msamsami commented Oct 5, 2024

@yozachar
I guess we can close this one as @bert2002 seems to agree with my earlier comment.

@yozachar yozachar closed this as not planned Won't fix, can't repro, duplicate, stale Oct 9, 2024
@bert2002
Copy link
Author

@yozachar I guess we can close this one as @bert2002 seems to agree with my earlier comment.

I thought more like btc_testnet_address to not break the btc_address.

@yozachar
Copy link
Collaborator

@msamsami you wanna take this up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msamsami msamsami

Labels
enhancement Issue/PR: A new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bert2002 @msamsami @yozachar