Skip to content

Issues from Nicolas Boulenguez #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 of 4 tasks
njsmith opened this issue Apr 23, 2018 · 3 comments
Closed
3 of 4 tasks

Issues from Nicolas Boulenguez #19

njsmith opened this issue Apr 23, 2018 · 3 comments

Comments

@njsmith
Copy link
Member

njsmith commented Apr 23, 2018

In private email, Nicolas Boulenguez reported the following issues they encountered while working on packaging async_generator for Debian:

  • The 1.9 tag is missing from Github.

  • The source says that the license is "MIT or APACHE2 (your choice)" but the 1.9 tarball on pypi only mentions MIT.

  • The 1.9 tarball on pypi contains no manual, neither the source nor the formatted version.

  • If this is easy for you to do, please consider removing stuff specific to github like .gitignore from the release tarball. People like me downloading the tarball instead of cloning the repository might have a different workflow with their own .gitignore settings. If removing files from the tarball is convoluted with github, forget this suggestion. This is only a matter of convenience.

@njsmith
Copy link
Member Author

njsmith commented Apr 23, 2018

Resolved the first issue by doing git push --tags origin. Apparently I forgot to do this after the last release, whoops.

@njsmith
Copy link
Member Author

njsmith commented Apr 23, 2018

#20 should fix all of this except for the .gitignore issue, which I can't replicate? I'll email him back about that.

@njsmith
Copy link
Member Author

njsmith commented Apr 24, 2018

Sounds like the .gitignore issue is that they were looking at the snapshots that Github generates on the "releases" page. I think we could override this by uploading our release artifacts to Github, but that's an extra step on every release and mostly pointless, since PyPI is the archive of record, so not going to do anything about that for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant