Files not correctly reported starting in 0.3.0

[ke-kialo]

When upgrading to 0.3.0 we noticed that the filenames of the failing tests were no longer correctly reported. This did not happen in 0.2.0 for us. However, also in 0.2.0 we saw incorrect line numbers for the failing tests.
In 0.3.0, the filename and line reported instead points to code within a hook (@pytest.hookimpl(tryfirst=True)) where we wrap pyfuncitem.obj in a lambda.

[edgarrmondragon]

@ke-kialo can you share a MRE? It's definitely tricky to track the code when there's plugins and hooks, and we don't have a test case which uses something like that.

[ska-kialo]

@edgarrmondragon we investigated this some more and found a solution. The key was to decorate the wrapping function with functools.wraps. For posterity's sake, I'll add both versions here:

Original:

@pytest.hookimpl(tryfirst=True)
def pytest_pyfunc_call(pyfuncitem):
    test_function = pyfuncitem.obj
    if iscoroutinefunction(test_function):
        timeout = pyfuncitem.config.getoption("async_timeout", default=None)
        pyfuncitem.obj = lambda **kwargs: await_sync(test_function(**kwargs), timeout=int(timeout) if timeout else None)

Fixed:

@pytest.hookimpl(tryfirst=True)
def pytest_pyfunc_call(pyfuncitem):
    test_function = pyfuncitem.obj
    if iscoroutinefunction(test_function):
        timeout = pyfuncitem.config.getoption("async_timeout", default=None)

        @functools.wraps(test_function)
        def wrapped(*args, **kwargs):
            return await_sync(test_function(*args, **kwargs), timeout=int(timeout) if timeout else None)

        pyfuncitem.obj = wrapped