Skip to content
This repository was archived by the owner on Apr 4, 2024. It is now read-only.

SocketManager: Add optional argument pass-through to socketio.AsyncServer constructor #14

Closed
inactivist opened this issue Dec 24, 2020 · 1 comment
Closed

SocketManager: Add optional argument pass-through to socketio.AsyncServer constructor #14

inactivist opened this issue Dec 24, 2020 · 1 comment

Comments

@inactivist
Copy link

inactivist commented Dec 24, 2020 •
edited
Loading

There are times when it may be necessary to be able to pass optional arguments to the AsyncServer constructor.

The current SocketManager constructor passes a fixed set of arguments when it initializes the _sio instance.

Perhaps an optional dict argument, socketio_server_args could be passed down into the AsyncServer constructor, as kwargs.

I'll try to work up a PR for this soon.
@inactivist inactivist changed the title Add kwargs pass-through to socketio.AsyncServer constructor SocketManager: Add optional argument pass-through to socketio.AsyncServer constructor Dec 24, 2020
@pyropy pyropy mentioned this issue Jun 17, 2021
Merged
@pyropy
Copy link
Owner

pyropy commented Jun 17, 2021 •
edited
Loading

I added async_mode argument that defaults to asgi. Take a look at #21 . Sorry because this took this long..

Let me know if that resolves your issue 😄

@pyropy pyropy closed this as completed Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@inactivist @pyropy