Skip to content

Commit 0d7cb20

Browse files
authored
test_simple: fix accidentally skipped test (#16777)
See #15716 (review) Signed-off-by: William Woodruff <[email protected]>
1 parent 5e05c1e commit 0d7cb20

File tree

1 file changed

+25
-12
lines changed

1 file changed

+25
-12
lines changed

tests/unit/api/test_simple.py

+25-12
Original file line numberDiff line numberDiff line change
@@ -460,27 +460,40 @@ def test_with_files_with_version_multi_digit(
460460
if renderer_override is not None:
461461
assert db_request.override_renderer == renderer_override
462462

463-
464-
def _update_context(context, content_type, renderer_override):
465-
if renderer_override != "json" or content_type in [
466-
simple.MIME_TEXT_HTML,
467-
simple.MIME_PYPI_SIMPLE_V1_HTML,
468-
]:
469-
return _valid_simple_detail_context(context)
470-
return context
471-
472-
def test_with_files_quarantined_omitted_from_index(self, db_request):
473-
db_request.accept = "text/html"
463+
@pytest.mark.parametrize(
464+
("content_type", "renderer_override"),
465+
CONTENT_TYPE_PARAMS,
466+
)
467+
def test_with_files_quarantined_omitted_from_index(
468+
self, db_request, content_type, renderer_override
469+
):
470+
db_request.accept = content_type
474471
project = ProjectFactory.create(lifecycle_status="quarantine-enter")
475472
releases = ReleaseFactory.create_batch(3, project=project)
476473
_ = [
477474
FileFactory.create(release=r, filename=f"{project.name}-{r.version}.tar.gz")
478475
for r in releases
479476
]
480477

481-
assert simple.simple_detail(project, db_request) == {
478+
context = {
482479
"meta": {"_last-serial": 0, "api-version": API_VERSION},
483480
"name": project.normalized_name,
484481
"files": [],
485482
"versions": [],
483+
"alternate-locations": [],
486484
}
485+
context = _update_context(context, content_type, renderer_override)
486+
487+
assert simple.simple_detail(project, db_request) == context
488+
489+
if renderer_override is not None:
490+
assert db_request.override_renderer == renderer_override
491+
492+
493+
def _update_context(context, content_type, renderer_override):
494+
if renderer_override != "json" or content_type in [
495+
simple.MIME_TEXT_HTML,
496+
simple.MIME_PYPI_SIMPLE_V1_HTML,
497+
]:
498+
return _valid_simple_detail_context(context)
499+
return context

0 commit comments

Comments
 (0)